Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasing v5 [TypeScript] Umbrella #4559

Closed
11 of 13 tasks
JedWatson opened this issue Apr 29, 2021 · 11 comments
Closed
11 of 13 tasks

Releasing v5 [TypeScript] Umbrella #4559

JedWatson opened this issue Apr 29, 2021 · 11 comments
Milestone

Comments

@JedWatson
Copy link
Owner

JedWatson commented Apr 29, 2021

As originally discussed in #4142 we've rewritten react-select in TypeScript (🙌 huge props to @Methuselah96 for the heavy lifting here!)

This issue is to track the work involved in merging the TypeScript conversion (#4489), and getting a new major version (v5) released.

Steps

@Eli-Black-Work
Copy link

Any chance of publishing a beta build to NPM? 🙂

@ebonow
Copy link
Collaborator

ebonow commented Jun 14, 2021

Everyone, please note that this major release will be a complete rewrite so we officially halted PR's until release so we can focus on addressing on breaking changes and documentation. It is absolutely inexcusable that so many PR's have not been addressed but also know that quite a bit focus around Menu positioning, scrolling and sizing behavior are being looked at holistically and may be resolved in batch as we continue to experiment with Popper as a solution.

@Methuselah96
Copy link
Collaborator

Methuselah96 commented Jul 9, 2021

We've released a beta. Give it a try and let us know if you run into any issues.

@nicoburns
Copy link

This new update looks great (especially the TypeScript support). However dropping IE11 support unfortunately makes it a non-starter for us. I was wondering whether that decision could be reconsidered. I see that the main reason for dropping IE11 support seems to be lack of support for CSS grid, but IE11 does partially support CSS grid so I am wondering if it would be possible to get the auto-sizing grid hack to work with it.

@ebonow Did you attempt to get the grid hack to work with IE11? Is there a specific reason why it won't work?

@yournatalita
Copy link

Is there a reason you got rid of makeAsyncSelect or other functions like this?

I found them useful for those who has a lot of custom logic or customization and wants to keep it in one component without copy-pasting, but still wants to separate Async and Common to different components for export and provide ability to have non-async and async select that had been customized in one place.

I might assume it would be handful to have it in v5 too.


If it is not a thing for v5, how you would recommend to fix this issue? (Sorry if it is a noob question as I am a bit lost without docs)

Should we use not a default export StateManagedSelect but a Select itself and customize data that passed to hooks based on our custom props? Or is there a better and easier way to do it?

@luxalpa
Copy link

luxalpa commented Sep 14, 2021

@nicoburns
I don't think it's worth it to invest into IE11 compatibility at this point as even Microsoft is no longer supporting it in their own apps and it's going to reach end of life quite soon:

On August 17, 2020, Microsoft published a timeline indicating that the Microsoft Teams product would stop supporting Internet Explorer 11 on November 30, 2020, and Microsoft 365 products will end Internet Explorer 11 support on August 17, 2021.[9] In May 2021, Microsoft announced that support for Internet Explorer 11 on editions of Windows 10 that are not in the Long-Term Servicing Channel (LTSC) will end on June 15, 2022.[10] Internet Explorer 11 will not be supported on any editions of Windows 11.[11]

@hansfpc
Copy link

hansfpc commented Sep 23, 2021

This new update looks great (especially the TypeScript support). However dropping IE11 support unfortunately makes it a non-starter for us. I was wondering whether that decision could be reconsidered. I see that the main reason for dropping IE11 support seems to be lack of support for CSS grid, but IE11 does partially support CSS grid so I am wondering if it would be possible to get the auto-sizing grid hack to work with it.

@ebonow Did you attempt to get the grid hack to work with IE11? Is there a specific reason why it won't work?

I think the world has to let IE die.
IE and "Progress" cannot be in the same phrase 😿
I decided that I will never again support IE in any piece of software I create.

@Methuselah96
Copy link
Collaborator

Methuselah96 commented Sep 24, 2021

5.0.0 has been released!

@Methuselah96 Methuselah96 unpinned this issue Sep 24, 2021
@Eli-Black-Work
Copy link

What needs to be done to update the documentation at https://www.npmjs.com/package/react-select ? It still references the old v2 to v3 upgrade guide, etc. 🙂

@Rall3n
Copy link
Collaborator

Rall3n commented Nov 15, 2021

Hello @Bosch-Eli-Black,

thanks for bringing this discrepancy to our attention. Seems like the packages README.md was forgotten during the preparations for the release.

@Eli-Black-Work
Copy link

@Rall3n Np! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants