-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kashkovsky intl a11y #3550
Closed
Closed
Kashkovsky intl a11y #3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s contains wrong statement
… the one supplied in props
Hello, is this going to happen somewhere in the near future? |
I would love this feature as well. Anything I can do to help getting this merged? |
Hey @magnusottosson, It would be a great help if you could help resolve the conflicts in this branch to get it merged, let me know if you're able! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category/accessibility
Issues or PRs related to accessibility
pr/bug-fix
PRs that are specifically addressing a bug
pr/needs-review
PRs that need to be reviewed to determine outcome
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a few bugs in #3358
Thanks to @Kashkovsky for doing most of the heavy lifting.
This PR makes it so that the accessibility prop is merged with a default accessibility config, instead of being a hard override.
As well as minor fixes to flow types around the newly exposed accessibility prop.