Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kashkovsky intl a11y #3550

Closed
wants to merge 4 commits into from
Closed

Kashkovsky intl a11y #3550

wants to merge 4 commits into from

Conversation

gwyneplaine
Copy link
Collaborator

Resolves a few bugs in #3358
Thanks to @Kashkovsky for doing most of the heavy lifting.
This PR makes it so that the accessibility prop is merged with a default accessibility config, instead of being a hard override.

{
 ...this.props.accessibility 
...defaultAccessibilityProps
}

As well as minor fixes to flow types around the newly exposed accessibility prop.

@mkamka
Copy link

mkamka commented Feb 12, 2020

Hello, is this going to happen somewhere in the near future?

@bladey bladey added pr/needs-review PRs that need to be reviewed to determine outcome and removed ready-for-review labels May 26, 2020
@bladey bladey added pr/bug-fix PRs that are specifically addressing a bug category/accessibility Issues or PRs related to accessibility labels Jun 4, 2020
@magnusottosson
Copy link

I would love this feature as well. Anything I can do to help getting this merged?

@bladey
Copy link
Contributor

bladey commented Jul 8, 2020

Hey @magnusottosson,

It would be a great help if you could help resolve the conflicts in this branch to get it merged, let me know if you're able! Thank you.

@radegran
Copy link

Hi @bladey,

I think #4161 will do it, please have a look.

@bladey
Copy link
Contributor

bladey commented Aug 24, 2020

Thank you @radegran! I'll close this in favor of #4161.

@bladey bladey closed this Aug 24, 2020
@ebonow ebonow mentioned this pull request Jan 21, 2021
@ebonow ebonow mentioned this pull request Feb 1, 2021
14 tasks
@dcousens dcousens deleted the Kashkovsky-intl-a11y branch October 19, 2022 05:32
@dcousens dcousens restored the Kashkovsky-intl-a11y branch October 19, 2022 05:32
@dcousens dcousens deleted the Kashkovsky-intl-a11y branch October 19, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category/accessibility Issues or PRs related to accessibility pr/bug-fix PRs that are specifically addressing a bug pr/needs-review PRs that need to be reviewed to determine outcome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants