Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aria messages cannot be localized and one of the messages contains wrong statement #3352

Closed
dmarcautan opened this issue Jan 15, 2019 · 1 comment · Fixed by #4414
Closed

Aria messages cannot be localized and one of the messages contains wrong statement #3352

dmarcautan opened this issue Jan 15, 2019 · 1 comment · Fixed by #4414
Labels
category/accessibility Issues or PRs related to accessibility issue/has-pr Issue has a PR attached to it that may solve the issue issue/reviewed Issue has recently been reviewed (mid-2020)

Comments

@dmarcautan
Copy link

The messages returned by 'instructionsAriaMessage' from accessibility/index are in plain English and there's no option to localize them. Also, when a value in multi-option setting is focused the messages returned states that item can be removed by pressing Enter that is not true.
Kashkovsky added a commit to Kashkovsky/react-select that referenced this issue Jan 16, 2019
@Kashkovsky
Issue JedWatson#3352: Aria messages cannot be localized and one of th…
499bb08 
…e messages contains wrong statement
Kashkovsky added a commit to Kashkovsky/react-select that referenced this issue Jan 16, 2019
@Kashkovsky
Issue JedWatson#3352: Aria messages cannot be localized and one of th…
1789b8c 
…e messages contains wrong statement
Kashkovsky added a commit to Kashkovsky/react-select that referenced this issue Jan 16, 2019
@Kashkovsky
Issue JedWatson#3352: Aria messages cannot be localized and one of th…
a8953c1 
…e messages contains wrong statement
@Kashkovsky
Copy link

#3358 Here's the PR for this issue.

gwyneplaine pushed a commit that referenced this issue May 10, 2019
@Kashkovsky @gwyneplaine
Issue #3352: Aria messages cannot be localized and one of the message…
5b1aa6c 
…s contains wrong statement
@jkjustjoshing jkjustjoshing mentioned this issue Jul 19, 2019
Closed
@bladey bladey added pr/needs-review PRs that need to be reviewed to determine outcome category/accessibility Issues or PRs related to accessibility labels May 28, 2020
@bladey bladey added cat/enhancement issue/reviewed Issue has recently been reviewed (mid-2020) and removed pr/needs-review PRs that need to be reviewed to determine outcome labels Jun 17, 2020
@bladey bladey linked a pull request Jun 23, 2020 that will close this issue
Issue #3352: Aria messages cannot be localized and one of the message… #3358
Closed
@bladey bladey added the issue/has-pr Issue has a PR attached to it that may solve the issue label Jul 6, 2020
This was referenced Dec 12, 2020
Closed
Closed
Closed
@ebonow ebonow mentioned this issue Jan 21, 2021
Closed
@ebonow ebonow mentioned this issue Feb 1, 2021
Merged
14 tasks
@ebonow ebonow linked a pull request Feb 3, 2021 that will close this issue
Aria Live Configuration #4414
Merged
14 tasks
@ebonow ebonow removed a link to a pull request Feb 7, 2021
Issue #3352: Aria messages cannot be localized and one of the message… #3358
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category/accessibility Issues or PRs related to accessibility issue/has-pr Issue has a PR attached to it that may solve the issue issue/reviewed Issue has recently been reviewed (mid-2020)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Aria Live Configuration ebonow/react-select
3 participants
@bladey @dmarcautan @Kashkovsky