Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-labels to Options #2036

Merged
merged 1 commit into from
Oct 18, 2017

Conversation

jasonchangxo
Copy link
Contributor

Note: This is my first time contributing to open source, so please let me know if there is anything you would like me to modify/change with this PR. Thanks!

I was working on accessibility/screen reader related fixes and a bug came up when testing with JAWS 18 and IE11 (on Win7). When navigating through the options, JAWS will only read "Link" for each option, but will not narrate the option label correctly to the user. For someone using a screen reader, this is a problem because they will have no idea what the options actually are. I added an aria-label to Options which will allow JAWS to correctly read the option.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.344% when pulling 1012fdb on jasonchangxo:add-aria-labels-to-options into 7523c20 on JedWatson:master.

@JedWatson
Copy link
Owner

Thanks for this @jasonchangxo, looks fantastic!

@JedWatson JedWatson merged commit b6ebce8 into JedWatson:master Oct 18, 2017
@JedWatson JedWatson mentioned this pull request Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants