-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARIA fixes #2035
ARIA fixes #2035
Conversation
Add aria-labels to options
Add logs for testing
Remove consolelogs and and edit aria-label value
Edit aria-label value
Edits for testing
Edit for testing
Edit aria-label values
Added open on enter functionality
bind onKeyDown method
@@ -94,7 +104,9 @@ var Value = function (_React$Component) { | |||
'span', | |||
{ className: 'Select-value-icon', | |||
'aria-hidden': 'true', | |||
'tabIndex': 0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
random question: why is aria-hidden=true on an element who can get focus with tabindex=0? This can result in a sort of nameless thingie when you focus on it.
Thanks for this - greatly appreciate the accessibility improvements. Two of the inclusions here have been raised separately (see #2037 and #2036) The remaining issue (being able to focus on values in the select) is actually something I'm exploring separately - not sure what the best design pattern is here, but I'm tempted to use something similar to the "pseudo-focus" that options get when the menu is open... Unfortunately, this PR makes changes to the If you're keen to contribute ARIA fixes it would be really helpful to have a separate PR for each change, with changes only made to the |
No description provided.