Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARIA fixes #2035

Closed
wants to merge 22 commits into from
Closed

ARIA fixes #2035

wants to merge 22 commits into from

Conversation

paulmillr
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.344% when pulling 2c206c8 on jasonchangxo:master into 7523c20 on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.344% when pulling 04315bf on jasonchangxo:master into 7523c20 on JedWatson:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.344% when pulling 81b1a89 on jasonchangxo:master into 7523c20 on JedWatson:master.

@@ -94,7 +104,9 @@ var Value = function (_React$Component) {
'span',
{ className: 'Select-value-icon',
'aria-hidden': 'true',
'tabIndex': 0,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

random question: why is aria-hidden=true on an element who can get focus with tabindex=0? This can result in a sort of nameless thingie when you focus on it.

@JedWatson
Copy link
Owner

Thanks for this - greatly appreciate the accessibility improvements.

Two of the inclusions here have been raised separately (see #2037 and #2036)

The remaining issue (being able to focus on values in the select) is actually something I'm exploring separately - not sure what the best design pattern is here, but I'm tempted to use something similar to the "pseudo-focus" that options get when the menu is open...

Unfortunately, this PR makes changes to the lib files which are overridden by the build system so it's not possible to actually preview the changes on the netlify deployment. With that in mind I'm going to close this PR since it can't be merged.

If you're keen to contribute ARIA fixes it would be really helpful to have a separate PR for each change, with changes only made to the src files so they can be discussed, tested and merged independently.

@JedWatson JedWatson closed this Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants