Rename, C API, minimum iOS target, and j make arg #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renamed libnode.framework to Node.framework Apple framework naming conventions declare that framework names should start with a capital letter, and the `lib` prefix is reserved for static/dynamic libraries. - Moved the node::Start method to a node_start C method, allowing Swift compatibility Swift does not support C++ interop, and importing the libnode framework into an iOS Swift project causes a build error. To fix this, I've wrapped the node::Start method into an equivalent C method, and exposed that in a C header. - Set minimum iOS target to iOS 9.0 There is no reason to only target the latest version of iOS, as this library does not use new APIs introduced in iOS 11. I arbitrarily set the target to iOS 9, which is a typical minimum version that you'll find in apps that are backwards compatible. - Add -j8 to make arguments for iOS target Adding the `j` flag to make in the ios_framework_prepare script speeds up builds immensely on multi-core machines, by building in parallel, with a maximum of 8 concurrent build runners.
|
Thanks for the PR @IMcD23 . Regarding iOS 9, it should be noticed that the project only builds binaries for 64 bits, so Applications won't be able to use it if they're 32 bits. I'll take some more time to do some tests but I'd like to suggest some changes in the meanwhile:
|
jaimecbernardo
requested changes
Nov 7, 2017
There was a problem hiding this comment.
Hi, @IMcD23. Thanks for your contribution.
This PR can be merged after the requested changes:
- Changing the framework's name to
NodeMobile.frameworkand the header file toNodeMobile.h. This is to avoid confusion with Node's node.h. - Replacing
make -j8formake -j $(getconf _NPROCESSORS_ONLN). That will make the number of threads adapt to the caller's CPU.
ian-mcdowell
force-pushed
the
framework-rename
branch
from
5d58b4e to
6a973f5
Compare
jaimecbernardo
approved these changes
Nov 27, 2017
|
Hi, @IMcD23, sorry for the delay. |
|
Landed in ec36bb6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed libnode.framework to Node.framework
Apple framework naming conventions declare that framework names should start with a capital letter, and the
libprefix is reserved for static/dynamic libraries.Moved the node::Start method to a node_start C method, allowing Swift compatibility
Swift does not support C++ interop, and importing the libnode framework into an iOS Swift project causes a build error. To fix this, I've wrapped the node::Start method into an equivalent C method, and exposed that in a C header.
Set minimum iOS target to iOS 9.0
There is no reason to only target the latest version of iOS, as this library does not use new APIs introduced in iOS 11.
I arbitrarily set the target to iOS 9, which is a typical minimum version that you'll find in apps that are backwards compatible.
Add -j8 to make arguments for iOS target
Adding the
jflag to make in the ios_framework_prepare script speeds up builds immensely on multi-core machines, by building in parallel, with a maximum of 8 concurrent build runners.Checklist
[x] Built iOS target using
./tools/ios_framework_prepare.sh[x] Tested Node.js framework in a Swift application