Fix issue 9863 - Change Tab selection order

CHANGELOG.md

@@ -24,6 +24,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
 - We added a new Integrity check for unscaped ampersands. [koppor#585](https://github.com/koppor/jabref/issues/585)
 - We added support for parsing `$\backslash$` in file paths (as exported by Mendeley). [forum#3470](https://discourse.jabref.org/t/mendeley-bib-import-with-linked-files/3470)
 - We added the possibility to automatically fetch entries when an ISBN is pasted on the main table. [#9864](https://github.com/JabRef/jabref/issues/9864)
+- We added key binding to focus on groups <kbd>Shift</kbd> + <kbd>Tab</kbd> [#9863](https://github.com/JabRef/jabref/issues/9863)
 
 ### Changed
 
@@ -53,6 +54,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
 - We moved the option to run JabRef in memory stick mode into the preferences dialog toolbar. [#9866](https://github.com/JabRef/jabref/pull/9866)
 - In case the library contains empty entries, they are not written to disk. [#8645](https://github.com/JabRef/jabref/issues/8645)
 - The formatter `remove_unicode_ligatures` is now called `replace_unicode_ligatures`. [#9890](https://github.com/JabRef/jabref/pull/9890)
+- The key binding to focus on entry table is changed to <kbd>Tab</kbd> [#9863](https://github.com/JabRef/jabref/issues/9863)
 
 ### Fixed
 

src/main/java/org/jabref/gui/JabRefFrame.java

@@ -320,6 +320,10 @@ private void initKeyBindings() {
                         getCurrentLibraryTab().getMainTable().requestFocus();
                         event.consume();
                         break;
+                    case FOCUS_GROUP_LIST:
+                        sidePane.getSidePaneComponent(SidePaneType.GROUPS).requestFocus();
+                        event.consume();
+                    break;
                     case NEXT_LIBRARY:
                         tabbedPane.getSelectionModel().selectNext();
                         event.consume();

src/main/java/org/jabref/gui/StateManager.java

@@ -19,9 +19,11 @@
 import javafx.collections.ObservableMap;
 import javafx.concurrent.Task;
 import javafx.scene.Node;
+import javafx.scene.control.TreeTableView;
 import javafx.util.Pair;
 
 import org.jabref.gui.edit.automaticfiededitor.LastAutomaticFieldEditorEdit;
+import org.jabref.gui.groups.GroupNodeViewModel;
 import org.jabref.gui.sidepane.SidePaneType;
 import org.jabref.gui.util.BackgroundTask;
 import org.jabref.gui.util.CustomLocalDragboard;
@@ -235,4 +237,5 @@ public List<String> getLastSearchHistory(int size) {
     public void clearSearchHistory() {
         searchHistory.clear();
     }
+
 }

src/main/java/org/jabref/gui/groups/GroupTreeView.java

@@ -609,4 +609,9 @@ public void execute() {
             }
         }
     }
+
+    /**
+     * Focus on GroupTree
+     */
+    public void requestFocusGroupTree() { groupTree.requestFocus(); }
 }

src/main/java/org/jabref/gui/keyboard/KeyBinding.java

@@ -55,7 +55,8 @@ public enum KeyBinding {
     FILE_LIST_EDITOR_MOVE_ENTRY_DOWN("File list editor, move entry down", Localization.lang("File list editor, move entry down"), "ctrl+DOWN", KeyBindingCategory.VIEW),
     FILE_LIST_EDITOR_MOVE_ENTRY_UP("File list editor, move entry up", Localization.lang("File list editor, move entry up"), "ctrl+UP", KeyBindingCategory.VIEW),
     FIND_UNLINKED_FILES("Search for unlinked local files", Localization.lang("Search for unlinked local files"), "shift+F7", KeyBindingCategory.QUALITY),
-    FOCUS_ENTRY_TABLE("Focus entry table", Localization.lang("Focus entry table"), "alt+1", KeyBindingCategory.VIEW),
+    FOCUS_ENTRY_TABLE("Focus entry table", Localization.lang("Focus entry table"), "TAB", KeyBindingCategory.VIEW),
+    FOCUS_GROUP_LIST("Focus group list", Localization.lang("Focus group list"), "shift+TAB", KeyBindingCategory.VIEW),
     HELP("Help", Localization.lang("Help"), "F1", KeyBindingCategory.FILE),
     IMPORT_INTO_CURRENT_DATABASE("Import into current library", Localization.lang("Import into current library"), "ctrl+I", KeyBindingCategory.FILE),
     IMPORT_INTO_NEW_DATABASE("Import into new library", Localization.lang("Import into new library"), "ctrl+alt+I", KeyBindingCategory.FILE),

src/main/java/org/jabref/gui/sidepane/SidePane.java

@@ -57,4 +57,8 @@ public BooleanBinding paneVisibleBinding(SidePaneType pane) {
     public SimpleCommand getToggleCommandFor(SidePaneType sidePane) {
         return new TogglePaneAction(stateManager, sidePane, preferencesService.getSidePanePreferences());
     }
+
+    public SidePaneComponent getSidePaneComponent(SidePaneType type) {
+        return viewModel.getSidePaneComponent(type);
+    }
 }

src/main/java/org/jabref/gui/sidepane/SidePaneComponent.java

@@ -10,6 +10,7 @@
 import javafx.scene.layout.VBox;
 
 import org.jabref.gui.actions.SimpleCommand;
+import org.jabref.gui.groups.GroupTreeView;
 import org.jabref.gui.icon.IconTheme;
 import org.jabref.logic.l10n.Localization;
 
@@ -71,4 +72,13 @@ private Node createHeaderView() {
     protected void addExtraButtonToHeader(Button button, int position) {
         this.buttonContainer.getChildren().add(position, button);
     }
+
+    public void requestFocus() {
+        for (Node child : getChildren()) {
+            if (child instanceof GroupTreeView) {
+                ((GroupTreeView) child).requestFocusGroupTree();
+                break;
+            }
+        }
+    }
 }

src/main/resources/l10n/JabRef_en.properties

@@ -1367,6 +1367,7 @@ Entry\ editor,\ previous\ panel\ 2=Entry editor, previous panel 2
 File\ list\ editor,\ move\ entry\ down=File list editor, move entry down
 File\ list\ editor,\ move\ entry\ up=File list editor, move entry up
 Focus\ entry\ table=Focus entry table
+Focus\ group\ list=Focus group list
 Import\ into\ current\ library=Import into current library
 Import\ into\ new\ library=Import into new library
 New\ article=New article