Fix issue 9863 - Change Tab selection order #9907

YifeiShi99 · 2023-05-16T04:03:44Z

Compulsory checks

Give feedback

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.
Options

src/main/java/org/jabref/gui/JabRefFrame.java

Siedlerchr · 2023-05-16T07:45:11Z

src/main/java/org/jabref/gui/keyboard/KeyBinding.java

@@ -55,7 +55,8 @@ public enum KeyBinding {
    FILE_LIST_EDITOR_MOVE_ENTRY_DOWN("File list editor, move entry down", Localization.lang("File list editor, move entry down"), "ctrl+DOWN", KeyBindingCategory.VIEW),
    FILE_LIST_EDITOR_MOVE_ENTRY_UP("File list editor, move entry up", Localization.lang("File list editor, move entry up"), "ctrl+UP", KeyBindingCategory.VIEW),
    FIND_UNLINKED_FILES("Search for unlinked local files", Localization.lang("Search for unlinked local files"), "shift+F7", KeyBindingCategory.QUALITY),
-    FOCUS_ENTRY_TABLE("Focus entry table", Localization.lang("Focus entry table"), "alt+1", KeyBindingCategory.VIEW),
+    FOCUS_ENTRY_TABLE("Focus entry table", Localization.lang("Focus entry table"), "TAB", KeyBindingCategory.VIEW),


Why did you change this?

this is changed to match the Tasks of focusing on entry table after pressing tab from the pull request #9863

Is it still possible to navigate away from the entry table? I would see tab as cycling though different ui components: Main menu entries, groups, main table, entry editor, ...

It should be possible to focus these elements using quick shortcut. Alr+1 was such a shortcut.

I think there is a bit of a misunderstanding of the issue:
Tab and Shift Tab are coming from the operating system and mean:
Tab: Forward navigation between controls
Shift + Tab: Backwards navigation between controls

The guy means: If you have the entry editor open, pressing shift + tab should navigate to the group. And if your focus is on the group; Navigation with tab should go forward to the
But I think this might be difficult. It depends on the order of the Nodes in the javafx scencegraph. Focus model etc.
I would rather add two extra shortcuts (like you did), but with separate shortcuts: like alt+1 or alt+2

Hi Siedlerchr, we can use alt + 1 to focus on the entry table (like before) and alt + 2 to focus on the group list

I think the reporter @DvP17 at #9863 really meant a proper Tab cycling order. I agree, however, that this is very difficult to implement. A workaround using Alt+1 and Alt+2 is OK for me.

Note that the hotkey system was revised at #1525. Updated at #1605.

Keys - new Keys - old Function

F7 alt + f Automatically set file links

F8 ctrl + shift + F7 Cleanup entries

alt + 1 ctrl + shift + E Focus entry table

alt + 2 ctrl + F9 Toggle entry/preview editor

alt + 3 ctrl + shift + G Toggle groups

alt + 4 F5 web search

alt + 0 - Open Openoffice/LibreOffice connection

ctrl + shift + F7 ctrl + f4 Synchronize file links

ctrl + shift R - Technical report

- alt + P Print entry preview

- ctrl + alt + T Hide/show toolbar

- ctrl+P Edit preamble

Maybe, we should think about propr key binding defaults. Alt+Number is used for both toggle and focus in the implementation of 2016.

Note that we have a blog article on a revised hotkey system in 2016: https://blog.jabref.org/2016/08/15/HotkeyRevision/

alt +1 and alt +2 are no longer used

src/main/java/org/jabref/gui/JabRefFrame.java

…m/YifeiShi99/jabref into implement-request-from-issue-9863

calixtus · 2023-05-17T17:45:49Z

src/main/java/org/jabref/gui/groups/GroupTreeView.java

+    /**
+     * Focus on GroupTree
+     */
+    public void requestFocusGroupTree() { groupTree.requestFocus(); }


Please fix the checkstyle issue

checkstyle issue fixed

calixtus · 2023-05-17T17:47:17Z

src/main/java/org/jabref/gui/sidepane/SidePaneComponent.java

+        for (Node child : getChildren()) {
+            if (child instanceof GroupTreeView) {
+                ((GroupTreeView) child).requestFocusGroupTree();
+                break;
+            }
+        }


Casting can be omitted by the new pattern matching feature of java

Suggested change

for (Node child : getChildren()) {

if (child instanceof GroupTreeView) {

((GroupTreeView) child).requestFocusGroupTree();

break;

}

}

for (Node child : getChildren()) {

if (child instanceof GroupTreeView groupTreeView) {

groupTreeView.requestFocusGroupTree();

break;

}

}

casting has been replaced by pattern matching

…m/YifeiShi99/jabref into implement-request-from-issue-9863

koppor · 2023-05-21T09:39:47Z

src/main/java/org/jabref/gui/keyboard/KeyBinding.java

@@ -55,7 +55,8 @@ public enum KeyBinding {
    FILE_LIST_EDITOR_MOVE_ENTRY_DOWN("File list editor, move entry down", Localization.lang("File list editor, move entry down"), "ctrl+DOWN", KeyBindingCategory.VIEW),
    FILE_LIST_EDITOR_MOVE_ENTRY_UP("File list editor, move entry up", Localization.lang("File list editor, move entry up"), "ctrl+UP", KeyBindingCategory.VIEW),
    FIND_UNLINKED_FILES("Search for unlinked local files", Localization.lang("Search for unlinked local files"), "shift+F7", KeyBindingCategory.QUALITY),
-    FOCUS_ENTRY_TABLE("Focus entry table", Localization.lang("Focus entry table"), "alt+1", KeyBindingCategory.VIEW),
+    FOCUS_ENTRY_TABLE("Focus entry table", Localization.lang("Focus entry table"), "TAB", KeyBindingCategory.VIEW),


Is it still possible to navigate away from the entry table? I would see tab as cycling though different ui components: Main menu entries, groups, main table, entry editor, ...

It should be possible to focus these elements using quick shortcut. Alr+1 was such a shortcut.

Siedlerchr · 2023-06-05T18:33:37Z

DevCall: Decision: Remove unused Preamble Store Change key binding
Reuse default keybinding alt + s to focus on the group

calixtus · 2023-06-10T12:37:18Z

Thank you for your contribution. We would be happy to see more contributions from your side.

* upstream/main: (68 commits) Fix issue 9863 - Change Tab selection order (#9907) New Crowdin updates (#9994) Enable editing typo with double clicking on field name in custom entry type (#9977) Remove "Field name:" from localization - we already have "Field name" (#9991) Changed database to catalog in org.jabref.gui.slr and org.jabref.logic.crawler (#9989) Use environment variables for hostname detection (#9910) Add cleanup activity for URL field (#9970) Fix freezing when fetching IBSN and no results are found (#9987) Make Group(Node)TreeViewModel more OO (#9978) Fix container for group item count still visible if display count is off (#9980) Fix paste of BibTeX data (#9985) Bring back SimplifyBoolean* and UnnecessaryParantheses (and refine guide) (#9981) Add new menu entry to remove braces from selection, aka unprotect it. (#9968) User specific comment (#9727) Bump org.openrewrite.recipe:rewrite-recipe-bom from 1.19.3 to 2.0.0 (#9975) Fix typos Remove non-needed link Fix typos Enable RemoveJavaDocAuthorTag (#9973) Bump com.fasterxml.jackson.datatype:jackson-datatype-jsr310 (#9974) ...

implement request from issue JabRef#9863

5768e98

calixtus reviewed May 16, 2023

View reviewed changes

src/main/java/org/jabref/gui/JabRefFrame.java Outdated Show resolved Hide resolved

Siedlerchr reviewed May 16, 2023

View reviewed changes

ThiloteE changed the title ~~implement request from issue #9863~~ Fix issue 9863 - Change Tab selection order May 16, 2023

ThiloteE added the component: keybinding label May 16, 2023

YifeiShi99 added 2 commits May 16, 2023 21:59

navigate through the children for grouptreeview and focus

5ba1532

Merge branch 'main' into implement-request-from-issue-9863

d2c78bf

calixtus reviewed May 17, 2023

View reviewed changes

src/main/java/org/jabref/gui/JabRefFrame.java Outdated Show resolved Hide resolved

YifeiShi99 added 2 commits May 16, 2023 22:58

add request focus method in sidepane

0a210c5

Merge branch 'implement-request-from-issue-9863' of https://github.co…

8148a93

…m/YifeiShi99/jabref into implement-request-from-issue-9863

calixtus reviewed May 17, 2023

View reviewed changes

YifeiShi99 added 6 commits May 17, 2023 21:15

fix checkstyle issue and pattern matching

ea1b53d

fix conflict in CHANGELOG.md

6598840

Merge branch 'main' into implement-request-from-issue-9863

b220d5a

.

31ab24c

Merge branch 'implement-request-from-issue-9863' of https://github.co…

ddb70c4

…m/YifeiShi99/jabref into implement-request-from-issue-9863

remove more extra space

e693985

koppor requested changes May 21, 2023

View reviewed changes

fix keybinding for shortcuts

1284e84

Siedlerchr added the status: devcall label Jun 3, 2023

Siedlerchr removed the status: devcall label Jun 5, 2023

Siedlerchr added 2 commits June 10, 2023 14:15

Merge branch 'main' into implement-request-from-issue-9863

7bdc35a

adhere to decall decision

89de583

Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 10, 2023

calixtus approved these changes Jun 10, 2023

View reviewed changes

calixtus merged commit 94f964c into JabRef:main Jun 10, 2023

calixtus added component: ui and removed status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Jun 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix issue 9863 - Change Tab selection order #9907

Fix issue 9863 - Change Tab selection order #9907

YifeiShi99 commented May 16, 2023 •

edited by ThiloteE

Loading

Compulsory checks

Siedlerchr May 16, 2023

YifeiShi99 May 17, 2023

koppor May 21, 2023

Siedlerchr May 21, 2023

YifeiShi99 May 23, 2023

koppor May 23, 2023

koppor May 23, 2023

Siedlerchr May 30, 2023

calixtus May 17, 2023

YifeiShi99 May 18, 2023

calixtus May 17, 2023

YifeiShi99 May 18, 2023

koppor May 21, 2023

Siedlerchr commented Jun 5, 2023

calixtus commented Jun 10, 2023

Keys - new	Keys - old	Function
F7	alt + f	Automatically set file links
F8	ctrl + shift + F7	Cleanup entries
alt + 1	ctrl + shift + E	Focus entry table
alt + 2	ctrl + F9	Toggle entry/preview editor
alt + 3	ctrl + shift + G	Toggle groups
alt + 4	F5	web search
alt + 0	-	Open Openoffice/LibreOffice connection
ctrl + shift + F7	ctrl + f4	Synchronize file links
ctrl + shift R	-	Technical report
-	alt + P	Print entry preview
-	ctrl + alt + T	Hide/show toolbar
-	ctrl+P	Edit preamble

Fix issue 9863 - Change Tab selection order #9907

Fix issue 9863 - Change Tab selection order #9907

Conversation

YifeiShi99 commented May 16, 2023 • edited by ThiloteE Loading

Compulsory checks

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Siedlerchr commented Jun 5, 2023

calixtus commented Jun 10, 2023

YifeiShi99 commented May 16, 2023 •

edited by ThiloteE

Loading