Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes string representation when detecting custom entry types. #5741

Merged
merged 2 commits into from
Dec 13, 2019
Merged

Changes string representation when detecting custom entry types. #5741

merged 2 commits into from
Dec 13, 2019

Conversation

jjsfernandez
Copy link
Contributor

fixes issue #5651
Adds new CellFactory that changes the way the BibEntryTypes are displayed on the table without changing the toString() method on BibEntryType.
It also removes unnecessary label.

Here is a screenshot on how the window looks now.
Screen Shot 2019-12-13 at 9 33 21 AM

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for bigger UI changes)
  • Checked documentation: Is the information available and up to date? If not: Issue created at https://github.com/JabRef/user-documentation/issues.

Jose Sinohui added 2 commits December 12, 2019 16:16
Changes string representation in ImportCustomEntryTypesDialog and rem…
8261e90 
…oves unnecessary label on ImportCustomEntryTypesDialog.fxml
updates CHANGELOG.MD
1e8bb5e
tobiasdiez
tobiasdiez approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to JabRef and thanks for your first contribution!

The code looks good to me! We have the convention that at least two developers need to review a pull request. So let's wait a bit for the second review before we merge. Shouldn't take too long!

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 13, 2019
Siedlerchr
Siedlerchr approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Looks also good from my side!
We really appreciate your contribution!

@Siedlerchr Siedlerchr merged commit aacceb5 into JabRef:master Dec 13, 2019
Siedlerchr added a commit that referenced this pull request Dec 14, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into changemergesdialog
21b4de3 
* upstream/master: (21 commits)
  New Crowdin translations (#5729)
  Update license of Oracle JDBC
  Changes string representation when detecting custom entry types. (#5741)
  Try to fix GitVersion
  Also run workflow on tag creation
  Add README.md with an initial help to work on command line para… (#5720)
  Bugfix for Multiscreen (#5738)
  Fix #2868 - keep source groups selected after drag and drop
  retrigger build
  Squashed 'src/main/resources/csl-styles/' changes from f71cd32..49a1841
  try to fix pull of csl styles
  try to fix csl update
  Fixed untranslated Strings issue #5701
  Fix #5603 - account for file extension in file name length (#5726)
  New translations JabRef_en.properties (French)
  Bump unirest-java from 3.2.00 to 3.3.00
  Bump postgresql from 42.2.8 to 42.2.9
  Bump tika-core from 1.22 to 1.23
  Fix upload to GitHub artifacts (#5712)
  Try to fix csl update (#5718)
  ...
@jjsfernandez jjsfernandez deleted the fix-issue-5651 branch December 16, 2019 14:47
@jjsfernandez jjsfernandez restored the fix-issue-5651 branch December 16, 2019 14:47
koppor pushed a commit that referenced this pull request Jan 1, 2022
Squashed 'buildres/csl/csl-styles/' changes from 60bf7d5..f78c707
1d32876 
f78c707 Update Turabian (full note) for 17.1.3.2 Reprint Editions (#5809)
2169ddc Create art-libraries-society-of-north-america-arlisna-reviews.csl (#5791)
94119a6 Create university-of-south-wales-harvard.csl (#5787)
470925c Update fachhochschule-sudwestfalen.csl (#5811)
1a9eff7 Create annals-of-public-and-cooperative-economics.csl (#5747)
d7477f2 Merge pull request #5368 from POBrien333/patch-862
113e683 Merge pull request #5812 from citation-style-language/apa-no-initials
62dacff Create universitat-oberta-de-catalunya-apa.csl
046482c Fix Organization Studies title
1213b95 Make oranization-studies dependent
c9641f4 Create apa-no-initials.csl
0b4e047 Modify american-journal-of-archaeology.csl (#5719)
ddeda4f Create journal-of-economic-impact.csl (#5707)
40c2696 Update gallia.csl (#5782)
5d5927a Create serbian-archives-of-medicine.csl (#5721)
2777954 Merge pull request #5807 from dhacker29/master
77e3fca Update Society of Biblical Literature Full Note for 6.1.6
4479a5a haaga-helia-university-of-applied-sciences-harvard.csl: no date cites need to be unique (#5726)
d00e046 Create university-of-roehampton-harvard.csl (#5732)
e76da40 Medicinski Razgledi -- fix locale
75b1554 Add original-date extra to proper place as per SBL Handbook 6.2.17-18 (#5725)
d43676e Update harvard-bournemouth-university.csl (#5667)
0312a39 Create ABNT NBR 6023:2018. UNESP – Faculdade de Engenharia de Guarati… (#5705)
6585ff9 Create sinergie-italian-journal-of-management.csl (#5776)
a7dc678 Create journal-of-global-health.csl (#5775)
02080ce Merge pull request #5800 from citation-style-language/validation-fixes
8b51d85 change s. d. to s.d. in french style for INBO reports (issue #2) (#5634)
1b4ec09 Create bloomsbury-academic.csl (#5741)
1f28d87 Create zeithistorische-forschungen.csl (#5766)
bb11942 Remove superfluous 'container' data from wiley-vch-books
06038a7 Remove et-al affixes
be96bd8 Remove et-al affixes from bibliotecae-it.csl
03a94e4 Remove more et-al affixes
07d7423 Revert non-et-al changes to universitat-basel-iberomanistik
f8e5fd8 Create medicinski-razgledi.csl (#5789)
b4df8ee Create dut-harvard.csl (#5762)
40855c4 Fix affixes on et-al
b4fe9b0 Merge pull request #5798 from citation-style-language/uris
3dc4aaf URL-encode documentation URLs
408a3a8 fixes citation-style-language/Sheldon#38
42aca5b Update biophysics-and-physicobiology.csl (#5751)
706bea0 Create universidade-do-porto-faculdade-de-engenharia-chicago-pt.csl (#5742)
269ff91 Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (#5797)
0ba51e7 Update el-profesional-de-la-informacion.csl (#5785)
dac3baf Create arthropod-systematics-and-phylogeny.csl (#5772)
9dff241 Merge pull request #5796 from dhacker29/patch-1
35949f4 Update turabian-fullnote-bibliography-no-ibid.csl
ccfb661 Merge pull request #5793 from benjaminmoon/patch-2
520e127 Update frontiers-medical-journals.csl (#5740)
ab629ab Update natura-croatica.csl (#5795)
60b2b17 Rename turabian-fullnote-bibliography-no-ibid to turabian-fullnote-bibliography-no-ibid.csl
ad4edff Create turabian-fullnote-bibliography-no-ibid
d9b956c Update monographs-of-the-palaeontographical-society.csl
3648ae6 Merge pull request #5792 from StianOby/fix-no-page-number-articles
e15b2f7 Update norsk-henvisningsstandard-for-rettsvitenskapelige-tekster.csl
d8778cf Removed "page" (s. ) term for articles that do not have page numbers.
409017c add medium field for eBooks to MLA 8th

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: f78c707
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjsfernandez @Siedlerchr @tobiasdiez