Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Added number of items found #5740

Closed
wants to merge 2 commits into from
Closed

[WIP] Added number of items found #5740

wants to merge 2 commits into from

Conversation

CloudFenrir
Copy link

@CloudFenrir CloudFenrir commented Dec 12, 2019 •
edited by calixtus
Loading

I added the a label showing the number of items found. I will continue working on the selected items in another commit.

  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for bigger UI changes)

Example image (look at the bottom):
image

@CloudFenrir CloudFenrir changed the title Added number of items found [WIP] Added number of items found Dec 12, 2019
tobiasdiez
tobiasdiez reviewed Dec 12, 2019
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! That's a good idea.

Please also add a bit of space after the total item count.

src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java
@@ -125,7 +124,8 @@ private void initialize() {
*/
if (entriesListView.getItems().size() == 1) {
selectAllNewEntries();
}
}
totalItems.textProperty().setValue(String.valueOf(entriesListView.getItems().size()));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be possible to bind the text directly to the size:
totalItems.textProperty().bind(Bindings.size(viewModel.getEntries())), which can then be moved to line 90.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually didn't work as you said, I just pushed some changes that were missing, I hope everything is ok.

@CloudFenrir CloudFenrir marked this pull request as ready for review December 16, 2019 08:47
@CloudFenrir CloudFenrir changed the title [WIP] Added number of items found Added number of items found Dec 17, 2019
koppor
koppor requested changes Dec 20, 2019
View reviewed changes
src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java
@@ -103,6 +103,19 @@ private void initialize() {
});
addToggle.getStyleClass().add("addEntryButton");
addToggle.selectedProperty().bindBidirectional(entriesListView.getItemBooleanProperty(entry));
addToggle.selectedProperty().addListener((observable, oldValue, newValue) -> {
if(observable.getValue()){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow our code formatting guidelines. The auto formatter should add some spaces here.

@koppor koppor changed the title Added number of items found [WIP] Added number of items found Dec 20, 2019
@koppor
Copy link
Member

koppor commented Jan 2, 2020

Happy new year to everyone!

@CloudFenrir May I ask whether you could find some time to finish this contribution?

@koppor koppor force-pushed the master branch 5 times, most recently from b8ef7b7 to 21c6e5e Compare March 4, 2020 17:02
@koppor koppor assigned calixtus and unassigned CloudFenrir Mar 31, 2020
@calixtus
Copy link
Member

Sadly, we did not hear from @CloudFenrir anymore. As we like this feature, we decided to adopt this PR.

@calixtus calixtus mentioned this pull request Apr 5, 2020
Merged
5 tasks
@calixtus calixtus closed this Apr 5, 2020
koppor pushed a commit that referenced this pull request Dec 20, 2021
Squashed 'buildres/csl/csl-styles/' changes from 60bf7d5..9dff241
55a9560 
9dff241 Merge pull request #5796 from dhacker29/patch-1
35949f4 Update turabian-fullnote-bibliography-no-ibid.csl
ccfb661 Merge pull request #5793 from benjaminmoon/patch-2
520e127 Update frontiers-medical-journals.csl (#5740)
ab629ab Update natura-croatica.csl (#5795)
60b2b17 Rename turabian-fullnote-bibliography-no-ibid to turabian-fullnote-bibliography-no-ibid.csl
ad4edff Create turabian-fullnote-bibliography-no-ibid
d9b956c Update monographs-of-the-palaeontographical-society.csl
3648ae6 Merge pull request #5792 from StianOby/fix-no-page-number-articles
e15b2f7 Update norsk-henvisningsstandard-for-rettsvitenskapelige-tekster.csl
d8778cf Removed "page" (s. ) term for articles that do not have page numbers.

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 9dff241
calixtus pushed a commit that referenced this pull request Dec 20, 2021
@koppor
[Bot] Update CSL styles (#8351)
f6d2ca2 
* Squashed 'buildres/csl/csl-styles/' changes from 60bf7d5..9dff241

9dff241 Merge pull request #5796 from dhacker29/patch-1
35949f4 Update turabian-fullnote-bibliography-no-ibid.csl
ccfb661 Merge pull request #5793 from benjaminmoon/patch-2
520e127 Update frontiers-medical-journals.csl (#5740)
ab629ab Update natura-croatica.csl (#5795)
60b2b17 Rename turabian-fullnote-bibliography-no-ibid to turabian-fullnote-bibliography-no-ibid.csl
ad4edff Create turabian-fullnote-bibliography-no-ibid
d9b956c Update monographs-of-the-palaeontographical-society.csl
3648ae6 Merge pull request #5792 from StianOby/fix-no-page-number-articles
e15b2f7 Update norsk-henvisningsstandard-for-rettsvitenskapelige-tekster.csl
d8778cf Removed "page" (s. ) term for articles that do not have page numbers.

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 9dff241

* Squashed 'buildres/csl/csl-locales/' changes from d5ee85de8e..95ee22b362

95ee22b362 Merge pull request #243 from jagrg/master
50498dce39 Fix pt-BR translation

git-subtree-dir: buildres/csl/csl-locales
git-subtree-split: 95ee22b36297a83e3346b950bf08728bfb31d664

Co-authored-by: github actions <jabrefmail+webfeedback@gmail.com>
koppor pushed a commit that referenced this pull request Jan 1, 2022
Squashed 'buildres/csl/csl-styles/' changes from 60bf7d5..f78c707
1d32876 
f78c707 Update Turabian (full note) for 17.1.3.2 Reprint Editions (#5809)
2169ddc Create art-libraries-society-of-north-america-arlisna-reviews.csl (#5791)
94119a6 Create university-of-south-wales-harvard.csl (#5787)
470925c Update fachhochschule-sudwestfalen.csl (#5811)
1a9eff7 Create annals-of-public-and-cooperative-economics.csl (#5747)
d7477f2 Merge pull request #5368 from POBrien333/patch-862
113e683 Merge pull request #5812 from citation-style-language/apa-no-initials
62dacff Create universitat-oberta-de-catalunya-apa.csl
046482c Fix Organization Studies title
1213b95 Make oranization-studies dependent
c9641f4 Create apa-no-initials.csl
0b4e047 Modify american-journal-of-archaeology.csl (#5719)
ddeda4f Create journal-of-economic-impact.csl (#5707)
40c2696 Update gallia.csl (#5782)
5d5927a Create serbian-archives-of-medicine.csl (#5721)
2777954 Merge pull request #5807 from dhacker29/master
77e3fca Update Society of Biblical Literature Full Note for 6.1.6
4479a5a haaga-helia-university-of-applied-sciences-harvard.csl: no date cites need to be unique (#5726)
d00e046 Create university-of-roehampton-harvard.csl (#5732)
e76da40 Medicinski Razgledi -- fix locale
75b1554 Add original-date extra to proper place as per SBL Handbook 6.2.17-18 (#5725)
d43676e Update harvard-bournemouth-university.csl (#5667)
0312a39 Create ABNT NBR 6023:2018. UNESP – Faculdade de Engenharia de Guarati… (#5705)
6585ff9 Create sinergie-italian-journal-of-management.csl (#5776)
a7dc678 Create journal-of-global-health.csl (#5775)
02080ce Merge pull request #5800 from citation-style-language/validation-fixes
8b51d85 change s. d. to s.d. in french style for INBO reports (issue #2) (#5634)
1b4ec09 Create bloomsbury-academic.csl (#5741)
1f28d87 Create zeithistorische-forschungen.csl (#5766)
bb11942 Remove superfluous 'container' data from wiley-vch-books
06038a7 Remove et-al affixes
be96bd8 Remove et-al affixes from bibliotecae-it.csl
03a94e4 Remove more et-al affixes
07d7423 Revert non-et-al changes to universitat-basel-iberomanistik
f8e5fd8 Create medicinski-razgledi.csl (#5789)
b4df8ee Create dut-harvard.csl (#5762)
40855c4 Fix affixes on et-al
b4fe9b0 Merge pull request #5798 from citation-style-language/uris
3dc4aaf URL-encode documentation URLs
408a3a8 fixes citation-style-language/Sheldon#38
42aca5b Update biophysics-and-physicobiology.csl (#5751)
706bea0 Create universidade-do-porto-faculdade-de-engenharia-chicago-pt.csl (#5742)
269ff91 Update universidade-do-porto-faculdade-de-engenharia-chicago.csl (#5797)
0ba51e7 Update el-profesional-de-la-informacion.csl (#5785)
dac3baf Create arthropod-systematics-and-phylogeny.csl (#5772)
9dff241 Merge pull request #5796 from dhacker29/patch-1
35949f4 Update turabian-fullnote-bibliography-no-ibid.csl
ccfb661 Merge pull request #5793 from benjaminmoon/patch-2
520e127 Update frontiers-medical-journals.csl (#5740)
ab629ab Update natura-croatica.csl (#5795)
60b2b17 Rename turabian-fullnote-bibliography-no-ibid to turabian-fullnote-bibliography-no-ibid.csl
ad4edff Create turabian-fullnote-bibliography-no-ibid
d9b956c Update monographs-of-the-palaeontographical-society.csl
3648ae6 Merge pull request #5792 from StianOby/fix-no-page-number-articles
e15b2f7 Update norsk-henvisningsstandard-for-rettsvitenskapelige-tekster.csl
d8778cf Removed "page" (s. ) term for articles that do not have page numbers.
409017c add medium field for eBooks to MLA 8th

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: f78c707
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez left review comments

@koppor koppor koppor requested changes

Assignees

@calixtus calixtus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CloudFenrir @koppor @calixtus @tobiasdiez