Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change key binding for cleanup from F8 to ALT+F8 #2496

Merged
merged 1 commit into from
Jan 29, 2017
Merged

Conversation

koppor
Copy link
Member

@koppor koppor commented Jan 29, 2017

Fixes #2251. This solution is the quick solution by changing the shortcut. The alternative is to change the ActionTable etcl.

  • Change in CHANGELOG.md described
  • [no] Tests created for changes
  • [n/a] Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • [n/a] Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • [n/a] If you changed the localization: Did you run gradle localizationUpdate?

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 29, 2017
@Siedlerchr
Copy link
Member

As quick fix imho okay. Maybe that will sooner or later be resolved with JavaFX.

@Siedlerchr Siedlerchr merged commit 8c8a435 into master Jan 29, 2017
@Siedlerchr Siedlerchr deleted the fix2251 branch January 29, 2017 19:27
Siedlerchr added a commit that referenced this pull request Feb 1, 2017
* upstream/master: (82 commits)
  Add access Rule for javafx to avoid Acces restricted in eclipse
  Fix apostrophe conversion (#2507)
  Fix Alain's name
  rename LocalizationBundle in Test folder (#2504)
  Fix eclipse bug again
  Update CHANGELOG.md
  Adapt IntelliJ Code Style.xml to checkstyle.xml
  Fix @param declaration and remove author to be consistent with other code
  Resolve conflicts using the versions javafx branch, not the master branch (and use alt+f8 instead of f8)
  Show development information
  Release v3.8.2
  Always override JabRef.vmoptions in the installation folder
  Update install4j from 6.1.3 to 6.1.4
  Update AUTHORS
  wget for new JREs
  Try vmOptionsFile
  Update JRE from 112 to 121
  Change key binding for cleanup from F8 to ALT+F8 (#2496)
  Use https URL of www.jabref.org
  Save test reports as build artifacts on circle ci
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants