Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut F8 not working #2251

Closed
grimes2 opened this issue Nov 8, 2016 · 9 comments
Closed

Shortcut F8 not working #2251

grimes2 opened this issue Nov 8, 2016 · 9 comments
Labels
component: ui [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs
Milestone

Comments

@grimes2
Copy link
Contributor

grimes2 commented Nov 8, 2016

JabRef 3.7-dev--snapshot--2016-11-08--master--fffad83
windows 10 10.0 amd64
Java 1.8.0_111

The shortcut F8 for Cleanup entries... is not working for me.

@stefan-kolb
Copy link
Member

Thank you for your report 😄
I can reproduce the behavior.

@stefan-kolb stefan-kolb added [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs component: ui labels Nov 8, 2016
@koppor
Copy link
Member

koppor commented Nov 8, 2016

@mairdl @Braunch Can you have a look?

@Braunch
Copy link
Contributor

Braunch commented Nov 10, 2016

I will have a look.

@Braunch
Copy link
Contributor

Braunch commented Nov 15, 2016

I think it has something to do with the mainTable selecting the authors row when pressing F8. It's a JTable functionality. I tried adding this line inputMap.put(KeyStroke.getKeyStroke("F8"), "none"); in the MainTable constructor. But this didn't override the F8 functionality. Does someone have any ideas how to fix this?

@matthiasgeiger
Copy link
Member

Just noticed, that F7 for "Automatically set file links" seems to work. Can you investigate the differences between these two functionalities?

@grimes2
Copy link
Contributor Author

grimes2 commented Nov 15, 2016

http://www.java-forum.org/thema/f8-im-jtable.70666/

Why not use Alt+F8?

@Braunch
Copy link
Contributor

Braunch commented Nov 15, 2016

We should try to evade the alt key since it often is reserved for OS specific keybindings. I found that link before and I read the KeyBindings Javadoc what brought me to my attempt. But it does not work and I don't know why. @matthiasgeiger same for F9, it's just because the F8 key is used by the JTable.

@stefan-kolb stefan-kolb added this to the v3.8 milestone Dec 8, 2016
@koppor koppor modified the milestones: v3.8.1, v3.8 Dec 16, 2016
@koppor
Copy link
Member

koppor commented Dec 16, 2016

I think, the decision is to change both F8 and F9 to include the Alt key.

@koppor koppor modified the milestones: v3.8.2, v3.8.1 Dec 22, 2016
@koppor
Copy link
Member

koppor commented Jan 29, 2017

F9 works perfectly here, so I change only F8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ui [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs
Projects
None yet
Development

No branches or pull requests

5 participants