Introduce convienent interface for ID-based fetcher #1998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
reviewed
Sep 16, 2016
| @@ -2302,3 +2302,5 @@ Select_first_entry= | |||
| Select_last_entry= | |||
|
|
|||
| Search_in_all_open_databases= | |||
|
|
|||
| Invalid_ISBN\:_'%0'.= | |||
There was a problem hiding this comment.
Sure we don't have a related error message already?
There was a problem hiding this comment.
Didn't find anything related to ISBN
There was a problem hiding this comment.
Ah, yes, we have Invalid_DOI already. It would make sense to have sth like Invalid_%0 which we can reuse for all id fetchers. (e.g. doi/isbn) so we
2 tasks
Siedlerchr
added a commit
that referenced
this pull request
Sep 17, 2016
* upstream/master: (103 commits) add id fetcher in biblatexmode (#2006) Check available help languages when opening specific help page (#2005) Remove help suffix at help pages (#2004) French localization: Jabref_fr: empty strings translated + correction of a glitch (#2000) Disable gradle daemon - maybe, this brings back the integration tests French localization: Menu: update (#1999) Introduce convienent interface for ID-based fetcher (#1998) Updated dependencies (#1994) Some minor code cleanups (#1991) Add missing calls to showEntryEditor (which ensures that currentEditor is right) Remove obsolete adjustSplitter calls Remove FocusRequester as it is not executed threaded Rename variable "form" to "editor" use JabRefPreferences.getInstance() to fix ci simplify code always use fetcherexception's message for output Quickfix: Time limit for integration tests Fix Exception when Close Dialog with 'X' Enable tests at CircleCI build to ensure that only binary passing the basic tests are released. Fix japanese language files ... # Conflicts: # src/main/java/net/sf/jabref/logic/cleanup/RenamePdfCleanup.java
zesaro
pushed a commit
to zesaro/jabref
that referenced
this pull request
Nov 22, 2016
* Introduce IdBasedParserFetcher * Add language text * Remove unused imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #1929. Since the changes in this PR are completely parallel to #1929, I will merge it as soon as the build passes.