New fetcher #1929
New fetcher #1929
Conversation
tobiasdiez
added
the
status: ready-for-review
| @@ -12,6 +12,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `# | |||
| ## [Unreleased] | |||
|
|
|||
| ### Changed | |||
| - Added fetcher for MathSciNet, zbMATH and Astrophysics Data System | |||
There was a problem hiding this comment.
Is it possible to add links to these databases?
|
|
||
| import net.sf.jabref.model.entry.BibEntry; | ||
|
|
||
| public interface Parser { |
There was a problem hiding this comment.
Could you add a JavaDoc comment here?
| new FieldFormatterCleanup(FieldName.ABSTRACT, new RemoveBracesFormatter()).cleanup(entry); | ||
| new FieldFormatterCleanup(FieldName.TITLE, new RemoveBracesFormatter()).cleanup(entry); | ||
| new FieldFormatterCleanup(FieldName.AUTHOR, new NormalizeNamesFormatter()).cleanup(entry); | ||
| new FieldFormatterCleanup("adsnote", new ClearFormatter()).cleanup(entry); |
There was a problem hiding this comment.
Could you provide example content in the comment and reason why it is not included? Personally, I keep as much information in the bib files as the styles ignore them nevertheless.
|
Thanks @koppor for reviewing. 4fc8551 is needed because it refactors the BibtexParser to confirm to the new Will incorporate your feedback. |
|
|
||
| private static String API_URL = "http://adsabs.harvard.edu/cgi-bin/nph-basic_connect"; | ||
| private static String API_QUERY_URL = "http://adsabs.harvard.edu/cgi-bin/nph-basic_connect"; |
|
Went through everything. Besides #1929 everything else are minor comments. |
* Refactor search based fetcher based on website and parser * Refactor BibtexParser * Refactor cleanup preferences * Add search-based fetcher for the Astrophysics Data System * Introduce EntryBasedFetcher * Add ADS as EntyBasedFetcher * Add comment about new ADS API * Add MathSciNet entry based fetcher * Add MathSciNet search fetcher * Add zbMath fetcher * Add Changelog * Remove header * Remove more headers * Include feedback * Rename GVKParser * Remove big * Remove unused imports * Fix failing GVK tests * Fix failing tests due to no subscription
A few new fetcher are introduced:
Also a bit of code was refactored (mainly to facilitate the development of fetcher).