-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue in comments Tab #10927
Merged
Merged
Fix issue in comments Tab #10927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoayGhreeb
changed the title
Update CommentsTab.java
Fix formatting issue in comments Tab
Feb 26, 2024
LoayGhreeb
changed the title
Fix formatting issue in comments Tab
Fix issue in comments Tab
Feb 26, 2024
Siedlerchr
reviewed
Feb 26, 2024
koppor
reviewed
Feb 26, 2024
koppor
reviewed
Feb 26, 2024
I could not check the failing ui test |
Siedlerchr
reviewed
Feb 27, 2024
koppor
approved these changes
Feb 27, 2024
Code looks good. Did not try fully, but let's see, what users report ^^. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10870
This issue occurs when the
defaultOwner
contains capital letters.For example, if
defaultOwner = Test
, theuserSpecificCommentField.name
will becomment-Test
, after saving it to the .bib file, it will be written ascomment-test
. As a result, every time thecommentsTab
is opened, it will contain bothcomment-Test
andcomment-test
fields.CHANGELOG.md
described in a way that is understandable for the average user (if applicable)