Non-editable user comments

[ror3d]

JabRef version

5.12 (latest release)

Operating system

Windows

Details on version and operating system

Windows 11

Checked with the latest development build (copy version output from About dialog)

• I made a backup of my libraries before testing the latest development version.
• I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

I am unsure of the cause for this, as a peer doesn't seem to have this problem.

1. Open the Comments tab for an entry
2. Add a comment in the bottom text-field labeled as Comment-<username>
3. Save the database
4. Notice that the notification about the file being edited outside JabRef appears
5. Proceed to Review the changes and to Merge them
6. Notice duplicated Comment-<username> field:
   
7. Accept the merge
8. Notice in the Comments tab, two text fields appear for the same user with the comment repeated:
   
9. Close the database (no need to save) and open it again
10. Navigate to the comments for entry where comment was added
11. Notice two comment fields there for the same user, the content only in the second one and not editable:
    

Appendix

@Article{ArticleID,

comment-roc = {Just a test comment},
comment-roc = {Just a test comment},

}

[Siedlerchr]

can you please test the latest development version? I can no longer reproduce the issue
https://builds.jabref.org/main/

[ror3d]

I still can reproduce it, yes.
Reproduction step 4 is also still happening, which I feel like might be part of the problem.

[LoayGhreeb]

Hi @Siedlerchr, I would like to work on this issue.

[Siedlerchr]

Sure, you're welcome to take a look at this issue

[github-actions]

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

[LoayGhreeb]

Hi @ror3d, can you tell me what exactly your username is? Is it roc or Roc?
You can check it from the preferences

[ror3d]

Hi,

Is that the setting where the name is taken from? it doesn't feel like it is, since the field is disabled unless the "Mark new entries" checkbox is selected. If that is indeed the setting, maybe it should be always editable and made more clear that it's what is used also for the personal comments. Maybe @Siedlerchr can weigh in on that.

Anyway, in that field I have it as Roc.

[LoayGhreeb]

Hi,

Is that the setting where the name is taken from? it doesn't feel like it is, since the field is disabled unless the "Mark new entries" checkbox is selected. If that is indeed the setting, maybe it should be always editable and made more clear that it's what is used also for the personal comments. Maybe @Siedlerchr can weigh in on that.

Anyway, in that field I have it as Roc.

Thanks for clarifying, @ror3d. The issue will be fixed in the next release. There was an issue if the owner name had uppercase or special characters.

Yes, this setting is to override the default owner name (which comes from your OS username), check the "Mark new entries" checkbox. This will allow you to edit the field and change the owner name.

[Siedlerchr]

If that is indeed the setting, maybe it should be always editable and made more clear that it's what is used also for the personal comments. Maybe @Siedlerchr can weigh in on that.

I agree with you. Originally, it's intended to be used for new entries to add the owner field. Now it's also used for comment fields. This allows sharing your bib files with others and everyone has it's own comment field. It should always be editable, independent of the checkbox
@LoayGhreeb Can you fix this as well?

[LoayGhreeb]

@LoayGhreeb Can you fix this as well?

Sure, I'll add this to the pull request

[koppor]

Is the original issue really fixed? 😅

[ror3d]

Indeed, the issue seems to be fixed with the latest code from main. It also fixes the problem where saving after editing the comment was detected as a different program modifying the file, which I guess was a side-effect of this issue.
Thanks!