-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Get New Themes!' Button for Web Page Integration #10349
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
79c381c
test
Jaovitosr bcc8cad
##################################################
Jaovitosr 446a784
Add 'Get New Themes!' Button for Web Page Integration
Jaovitosr 6b87896
Add 'Get New Themes!' Button for Web Page Integration
Jaovitosr 61439e8
Add 'Get New Themes!' Button for Web Page Integration
Jaovitosr 1204fbd
Add 'Get New Themes!' Button for Web Page Integration
Jaovitosr e62b659
Add 'Get New Themes!' Button for Web Page Integration
Jaovitosr d60c99a
Update JabRef_en.properties
Jaovitosr 2a98bc4
Merge branch 'main' into fixing_issue_10243
Siedlerchr ee8f14d
Implemented SLF4j logger in GeneralTabViewModel.java
Jaovitosr 30a26ca
Merge remote-tracking branch 'upstream/main' into fixing_issue_10243
Siedlerchr 7464238
move theme Types to their own class
Siedlerchr 5d36745
import exception
Siedlerchr 4ee45f2
openRewrite, changelog
Siedlerchr 7c64b1a
Merge branch 'main' into fixing_issue_10243
Siedlerchr d69519b
use hyperlink
Siedlerchr be514c4
Add dependency
koppor 7a79793
Revert "Add dependency"
koppor 46b8c31
using three dots as "more to come"
Jaovitosr 9c5dae8
change to lower case
Jaovitosr bb8c710
Update CHANGELOG.md
Jaovitosr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package org.jabref.gui.theme; | ||
|
||
import org.jabref.logic.l10n.Localization; | ||
|
||
public enum ThemeTypes { | ||
|
||
LIGHT(Localization.lang("Light")), | ||
DARK(Localization.lang("Dark")), | ||
CUSTOM(Localization.lang("Custom...")); | ||
|
||
private final String displayName; | ||
|
||
ThemeTypes(String displayName) { | ||
this.displayName = displayName; | ||
} | ||
|
||
public String getDisplayName() { | ||
return displayName; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A model opening a browser seems strange. - CAn you move the
openBrowser
code from the model to here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, for sure!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@koppor this is done elsewhere as well
For example in the about dialog.
And this is our standard approach. All logic goes to the view model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then, I'll move forward with merge - and will put an agenda item for on our DevCall agenda.