Add 'Get New Themes!' Button for Web Page Integration #10349

Jaovitosr · 2023-09-08T17:36:39Z

Add 'Get New Themes!' Button for Web Page Integration for issue #10243

Used hyperlink now

The change was made at the request of a user who wanted the option to discover new themes for the application more easily and conveniently, such as through a button within the application that redirects them to a web page in their default browser.

The change was implemented through a button added in Preferences > General, located just below the option for selecting new themes via a local directory. Modifications were made to the 'GeneralTab.fxml' and 'GeneralTab.java' files, through which the button was created and the method to execute its function was implemented, respectively.

Mandatory checks

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

# Write a title summarizing what this commit does. # Start with an uppercase imperative verb, such as # Add, Drop, Fix, Refactor, Bump; see ideas below. # Think of your title as akin to an email subject, # so you don't need to end with a sentence period. # Use 50 char maximum, which is this line's width. ################################################## Add 'Get New Themes!' Button for Web Page Integration ######################################################################## # Why is this change happening? # Describe the purpose, such as a goal, or use case, or user story, etc. # For every line, use 72 char maximum width, which is this line's width. ######################################################################## The change was made at the request of a user who wanted the option to discover new themes for the application more easily and conveniently, such as through a button within the application that redirects them to a web page in their default browser. ######################################################################## # How is this change happening? # Describe any relevant algorithms, protocols, implementation spec, etc. # For every line, use 72 char maximum width, which is this line's width. ######################################################################## The change was implemented through a button added in Preferences > General, located just below the option for selecting new themes via a local directory. Modifications were made to the 'GeneralTab.fxml' and 'GeneralTab.java' files, through which the button was created and the method to execute its function was implemented, respectively

The change was made at the request of a user who wanted the option to discover new themes for the application more easily and conveniently, such as through a button within the application that redirects them to a web page in their default browser. The change was implemented through a button added in Preferences > General, located just below the option for selecting new themes via a local directory. Modifications were made to the 'GeneralTab.fxml' and 'GeneralTab.java' files, through which the button was created and the method to execute its function was implemented, respectively

src/main/java/org/jabref/gui/preferences/general/GeneralTab.fxml

Siedlerchr

Thanks for your PR! I added some comments for improvements

src/main/java/org/jabref/gui/preferences/general/GeneralTab.fxml

src/main/java/org/jabref/gui/preferences/general/GeneralTab.java

The change was made at the request of a user who wanted the option to discover new themes for the application more easily and conveniently, such as through a button within the application that redirects them to a web page in their default browser. The change was implemented through a button added in Preferences > General, located just below the option for selecting new themes via a local directory. Modifications were made to the 'GeneralTab.fxml' and 'GeneralTab.java' files, through which the button was created and the method to execute its function was implemented, respectively Some requested changes were resolved.

src/main/java/org/jabref/gui/preferences/general/GeneralTab.java

The change was made at the request of a user who wanted the option to discover new themes for the application more easily and conveniently, such as through a button within the application that redirects them to a web page in their default browser. The change was implemented through a button added in Preferences > General, located just below the option for selecting new themes via a local directory. Modifications were made to the 'GeneralTab.fxml' and 'GeneralTab.java' files, through which the button was created and the method to execute its function was implemented, respectively Some requested changes were resolved, such as Localizing de new button text and using de method JabRefDesktop.openBrowser().

src/main/java/org/jabref/gui/preferences/general/GeneralTab.java

The change was made at the request of a user who wanted the option to discover new themes for the application more easily and conveniently, such as through a button within the application that redirects them to a web page in their default browser. The change was implemented through a button added in Preferences > General, located just below the option for selecting new themes via a local directory. Modifications were made to the 'GeneralTab.fxml' and 'GeneralTab.java' files, through which the button was created and the method to execute its function was implemented, respectively Some requested changes were resolved, such as Localizing de new button text and using de method JabRefDesktop.openBrowser(). The method openBrowser() was also moved to the viewModel, and a Logger was used for exception handling.

src/main/resources/l10n/JabRef_en.properties

src/main/java/org/jabref/gui/preferences/general/GeneralTabViewModel.java

Added SLF4j logger in GeneralTabViewModel for improved logging and debugging. Followed Checkstyle recommendations for variable order. This change enhances code readability and maintainability.

Siedlerchr · 2023-09-16T18:39:14Z

Please have a look at the failing tests

* upstream/main: update javafx to 20.0.2 [Bot] Update journal abbreviation lists (JabRef#10387) Fix hang when exporting at the CLI (JabRef#10383) Add tests for EntryComperatorTest (JabRef#10357) Update CSL styles Remove empty lines One more Refinements Update docs/getting-into-the-code/guidelines-for-setting-up-a-local-workspace/intellij-89-run-with-intellij.md Add some more exports Refine IntelliJ howto Fix localization Adds LaTeX integrity check based on SnuggleTeX Fix casing "macOS" and "JabRef", vendor: JabRef e.V.

replace logger with dialog

koppor

In JabRef, we tend to use lower case. See the preference window.

Moreover, if there is more to come, JabRef typically uses three dots at the end.

I made the suggestions in the code.

CHANGELOG.md

src/main/java/org/jabref/gui/preferences/general/GeneralTab.fxml

src/main/resources/l10n/JabRef_en.properties

This reverts commit be514c4.

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

koppor

One minor thing, but I think, it's important from a software design perspective.

koppor · 2023-09-20T22:38:56Z

src/main/java/org/jabref/gui/preferences/general/GeneralTab.java

+
+    @FXML
+    public void openBrowser() {
+        viewModel.openBrowser();


A model opening a browser seems strange. - CAn you move the openBrowser code from the model to here?

Yes, for sure!

@koppor this is done elsewhere as well
For example in the about dialog.
And this is our standard approach. All logic goes to the view model

Then, I'll move forward with merge - and will put an agenda item for on our DevCall agenda.

Jaovitosr added 3 commits September 8, 2023 13:37

test

79c381c

Siedlerchr reviewed Sep 8, 2023

View reviewed changes

src/main/java/org/jabref/gui/preferences/general/GeneralTab.fxml Outdated Show resolved Hide resolved

Siedlerchr requested changes Sep 8, 2023

View reviewed changes

src/main/java/org/jabref/gui/preferences/general/GeneralTab.fxml Outdated Show resolved Hide resolved

src/main/java/org/jabref/gui/preferences/general/GeneralTab.java Outdated Show resolved Hide resolved

Siedlerchr added the status: changes required Pull requests that are not yet complete label Sep 8, 2023

Siedlerchr reviewed Sep 10, 2023

View reviewed changes

src/main/java/org/jabref/gui/preferences/general/GeneralTab.java Outdated Show resolved Hide resolved

Jaovitosr added 2 commits September 10, 2023 18:45

Siedlerchr reviewed Sep 11, 2023

View reviewed changes

src/main/java/org/jabref/gui/preferences/general/GeneralTab.java Outdated Show resolved Hide resolved

Siedlerchr reviewed Sep 11, 2023

View reviewed changes

src/main/resources/l10n/JabRef_en.properties Outdated Show resolved Hide resolved

Update JabRef_en.properties

d60c99a

Jaovitosr requested a review from Siedlerchr September 11, 2023 23:14

Siedlerchr reviewed Sep 12, 2023

View reviewed changes

src/main/java/org/jabref/gui/preferences/general/GeneralTabViewModel.java Outdated Show resolved Hide resolved

Siedlerchr and others added 2 commits September 12, 2023 08:21

Merge branch 'main' into fixing_issue_10243

2a98bc4

Implemented SLF4j logger in GeneralTabViewModel.java

ee8f14d

Added SLF4j logger in GeneralTabViewModel for improved logging and debugging. Followed Checkstyle recommendations for variable order. This change enhances code readability and maintainability.

Siedlerchr added 5 commits September 18, 2023 20:56

move theme Types to their own class

7464238

replace logger with dialog

import exception

5d36745

openRewrite, changelog

4ee45f2

Merge branch 'main' into fixing_issue_10243

7c64b1a

Siedlerchr added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed status: changes required Pull requests that are not yet complete labels Sep 18, 2023

Siedlerchr marked this pull request as ready for review September 18, 2023 19:27

use hyperlink

d69519b

Siedlerchr enabled auto-merge September 19, 2023 19:01

koppor requested changes Sep 19, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

src/main/java/org/jabref/gui/preferences/general/GeneralTab.fxml Outdated Show resolved Hide resolved

src/main/resources/l10n/JabRef_en.properties Outdated Show resolved Hide resolved

koppor and others added 3 commits September 19, 2023 23:14

Add dependency

be514c4

Revert "Add dependency"

7a79793

This reverts commit be514c4.

using three dots as "more to come"

46b8c31

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

auto-merge was automatically disabled September 19, 2023 22:48
Head branch was pushed to by a user without write access

Jaovitosr and others added 2 commits September 19, 2023 19:49

change to lower case

9c5dae8

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

Update CHANGELOG.md

bb8c710

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

koppor requested changes Sep 20, 2023

View reviewed changes

koppor merged commit 01f65ea into JabRef:main Sep 21, 2023
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 'Get New Themes!' Button for Web Page Integration #10349

Add 'Get New Themes!' Button for Web Page Integration #10349

Jaovitosr commented Sep 8, 2023 •

edited by Siedlerchr

Loading

Siedlerchr left a comment

Siedlerchr commented Sep 16, 2023

koppor left a comment

koppor left a comment

koppor Sep 20, 2023

Jaovitosr Sep 20, 2023

Siedlerchr Sep 21, 2023 •

edited

Loading

koppor Sep 21, 2023

Add 'Get New Themes!' Button for Web Page Integration #10349

Add 'Get New Themes!' Button for Web Page Integration #10349

Conversation

Jaovitosr commented Sep 8, 2023 • edited by Siedlerchr Loading

Mandatory checks

Siedlerchr left a comment

Choose a reason for hiding this comment

Siedlerchr commented Sep 16, 2023

koppor left a comment

Choose a reason for hiding this comment

koppor left a comment

Choose a reason for hiding this comment

koppor Sep 20, 2023

Choose a reason for hiding this comment

Jaovitosr Sep 20, 2023

Choose a reason for hiding this comment

Siedlerchr Sep 21, 2023 • edited Loading

Choose a reason for hiding this comment

koppor Sep 21, 2023

Choose a reason for hiding this comment

Jaovitosr commented Sep 8, 2023 •

edited by Siedlerchr

Loading

Siedlerchr Sep 21, 2023 •

edited

Loading