Update Java Keyring dependency #10252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refs #10044 (comment). @credmond Could you test this PR on your GNOME. Hopefully, it works. If not, we have some bigger issues to solve. (The next comment should contain the deep link to the directory of the build) Refs javakeyring/java-keyring#90 (where we updated a dependency of Java Keyring to get it work) and advisedtesting/AdvisedTesting#115 (where we updated a testing dependency of Java Keyring to enable testing it on JDK17) |
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Unfortunately, same problem. The stack-trace @ 15:51 occurred after I attempted to save a proxy password: |
Siedlerchr
approved these changes
Sep 1, 2023
|
We tried on MacOS and Windows. We update, because it does not make things worse. Follow-up issue #10274 created. |
|
I found the root cause, I believe. I'll update the other ticket with info. |
|
@credmond Yeah that sounds great, thanks already in advance! |
Siedlerchr
added a commit
to Luggas4you/jabref
that referenced
this pull request
Sep 2, 2023
* upstream/main: (53 commits) Update CHANGELOG.md Update CHANGELOG.md Update CHANGELOG.md adjust snapcraft Show development information Add merge_group trigger on tests and deployment fix changelog link change to release Update CHANGELOG.md Updated external-libraries.md (JabRef#10272) Update Java Keyring dependency (JabRef#10252) New translations JabRef_en.properties (Dutch) Remove CCS as it is no longer available (JabRef#10270) New translations JabRef_en.properties (Dutch) Fixed saving radio button choice under specified keywords (JabRef#10255) Unlocalize LOGGER output (and change log level) Squashed 'buildres/csl/csl-styles/' changes from 795ad0c772..2a122e3fa0 Update CHANGELOG.md Update CHANGELOG.md Fixed not showing selected group properties ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java Keyring released a new version, which integrated our fix javakeyring/java-keyring#90.
Follow-up to #10224, refs #8055.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)