Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable password and apikey persistency if keyring is unavailable #10224

Merged
merged 7 commits into from
Aug 28, 2023
Merged

Disable password and apikey persistency if keyring is unavailable #10224

merged 7 commits into from
Aug 28, 2023

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Aug 28, 2023 •
edited
Loading

Followup to #10044

Disable persistency if keystore does not work
Changelog not necessary, since the basic mechanic is introduced in v5.10

grafik
grafik

Disabled:
grafik

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus calixtus added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers preferences labels Aug 28, 2023
@calixtus calixtus changed the title Introduced method isKeyRingAvailable Disable password and apikey persistency if keyring is unavailable Aug 28, 2023
@calixtus
Merge remote-tracking branch 'upstream/main' into keyringAvailable
b510a74 
# Conflicts:
#	src/main/java/org/jabref/gui/preferences/network/NetworkTabViewModel.java
#	src/main/java/org/jabref/gui/preferences/websearch/WebSearchTabViewModel.java
#	src/main/java/org/jabref/logic/importer/ImporterPreferences.java
@calixtus calixtus merged commit 6ac018b into main Aug 28, 2023
12 of 13 checks passed
@calixtus calixtus deleted the keyringAvailable branch August 28, 2023 21:44
@github-actions
Copy link
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@koppor koppor mentioned this pull request Aug 30, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
preferences status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calixtus @Siedlerchr