Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: JSON serialization/deserialization, cmd handling, admin request #33

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

GaMeRaM
Copy link
Contributor

@GaMeRaM GaMeRaM commented Nov 12, 2024

  • Corrected paths handling so now it correctly escapes strings that have spaces
  • Fixed empty 'env' key handing in apps.json
  • Fixed checks for existing games and games that launch using steam:// cmd
  • Added request to launch as admin if needed
  • Wait for button press before exiting to make reading logs possible

@JMTK
Copy link
Owner

JMTK commented Nov 19, 2024

Thanks for the fixes! I ended up having to just fully delete my apps array in my json file because of just some serialization issues, but that fully fixed it on my end.

I think possibly it would be better in the future to ignore "invalid" properties during deserialization rather than fully break but that's a separate issue. That way this app isn't contingent on the existing apps.json on being valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants