Unhandled exception when trying to fill the library

[GaMeRaM]

I did run it as administrator.
It doesn't seem to be based on the specific game.
When i moved Abiotic Factor out of the folder - it failed on the next game that had exe in its folder

[JMTK]

**GaMeRaM ** commented Nov 8, 2024

I just pushed a new version, 1.8.2, can you try it out?
https://github.com/JMTK/SunshineGameFinder/releases/tag/1.8.2

[GaMeRaM]

I appreciate the fast fix!

Seems like there is another problem. Sunshine on windows wraps booleans and numbers in quotes. And it breaks json parser in SunshineGameFinder:


When i convert them from strings to the actual types GameFinder works correctly, but resulting config seems to break the Sunshine. No games are shown in Moonlight on android

There is also a difference that Sunshine writes empty parameters like output as empty strings but GameFinder writes them as null

Also there is a note in Sunshine UI that if path to executable contains spaces - you should wrap the path in quotes. GameFinder currently doesnt do that (and kinda breaks previous games. It now added unicode characters instead of escaped quotes)

[JMTK]

I appreciate the fast fix!

Seems like there is another problem. Sunshine on windows wraps booleans and numbers in quotes. And it breaks json parser in SunshineGameFinder: When i convert them from strings to the actual types GameFinder works correctly, but resulting config seems to break the Sunshine. No games are shown in Moonlight on android

There is also a difference that Sunshine writes empty parameters like output as empty strings but GameFinder writes them as null

Also there is a note in Sunshine UI that if path to executable contains spaces - you should wrap the path in quotes. GameFinder currently doesnt do that (and kinda breaks previous games. It now added unicode characters instead of escaped quotes)

Would you mind sharing your apps.json so I can use it for testing? It seems your configuration varies wildly from what I am testing against so I wanna make sure I meet all the use cases

[JMTK]

Hi @GaMeRaM I was able to reproduce your issue, would you kindly try 1.9.2? https://github.com/JMTK/SunshineGameFinder/releases/tag/1.9.2

If that's still not working, would you be able to share your apps.json so I can further troubleshoot?

Thank you!

[GaMeRaM]

Hi @GaMeRaM I was able to reproduce your issue, would you kindly try 1.9.2? https://github.com/JMTK/SunshineGameFinder/releases/tag/1.9.2

If that's still not working, would you be able to share your apps.json so I can further troubleshoot?

Thank you!

I'm sorry, but seems like this release doesnt contain a compiled binary

Added three files:

1. originally generated by sunshine and one game added using sunshine web ui: 1_apps_sunshine_generated.json
2. original file fixed by hand to make it work with gamefinder: 2_apps_sunshine_compatible.json
3. apps.json generated by GameFinder based on File 2: 3_apps_gamefinder.json

[JMTK]

Hi @GaMeRaM I was able to reproduce your issue, would you kindly try 1.9.2? https://github.com/JMTK/SunshineGameFinder/releases/tag/1.9.2
If that's still not working, would you be able to share your apps.json so I can further troubleshoot?
Thank you!

I'm sorry, but seems like this release doesnt contain a compiled binary

Added three files:

1. originally generated by sunshine and one game added using sunshine web ui: 1_apps_sunshine_generated.json
2. original file fixed by hand to make it work with gamefinder: 2_apps_sunshine_compatible.json
3. apps.json generated by GameFinder based on File 2: 3_apps_gamefinder.json

Weird, sorry about that. Seems like the upload originally failed. Should be good now. I'll test out your files in the meantime! Thank you

[GaMeRaM]

Tried it with file 1

Seems like it doesnt like empty env key in apps.json (which comes empty default with sunshine)

[JMTK]

Tried it with file 1

Seems like it doesnt like empty env key in apps.json (which comes empty default with sunshine)

Interesting, mine is also empty but I'm not seeing that issue. I'll do some more testing!

[GaMeRaM]

Tried to fix it myself and it seems to be working correctly (however it may be wrong in Env departament)
https://github.com/GaMeRaM/SunshineGameFinder/tree/json-serialiser-fix
(Sorry if code looks jank. I'm not a C# programmer, so there is some AI stuff that may be weird)

Also found a bug. GameFinder will remove any game that starts through 'steam://...' cmd if removeUninstalled is true

[JMTK]

Tried to fix it myself and it seems to be working correctly (however it may be wrong in Env departament) https://github.com/GaMeRaM/SunshineGameFinder/tree/json-serialiser-fix (Sorry if code looks jank. I'm not a C# programmer, so there is some AI stuff that may be weird)

Also found a bug. GameFinder will remove any game that starts through 'steam://...' cmd if removeUninstalled is true

Awesome I think your code looks good! Thanks for looking into it. Feel free to go ahead and open a PR and list all the improvements I'd be happy to merge it in!

[GaMeRaM]

#33

[strazto]

Sounds like the solution is in the pipeline but I get a similar issue with 1.9.2 , related to the env key it seems:

Unhandled exception: Newtonsoft.Json.JsonSerializationException: Unable to find a constructor to use for type SunshineGameFinder.SunshineConfig. A class should either have a default constructor, one constructor with arguments or a constructor marked with the JsonConstructor attribute. Path 'env', line 2, position 10.
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateNewObject(JsonReader, JsonObjectContract, JsonProperty , JsonProperty , String , Boolean& )
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader , Type, JsonContract, JsonProperty, JsonContainerContract, JsonProperty, Object)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader , Type, JsonContract, JsonProperty, JsonContainerContract, JsonProperty, Object)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader , Type, Boolean)
   at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader , Type)
   at Newtonsoft.Json.JsonSerializer.Deserialize(JsonReader , Type)
   at Newtonsoft.Json.JsonConvert.DeserializeObject(String , Type, JsonSerializerSettings)
   at Newtonsoft.Json.JsonConvert.DeserializeObject[T](String , JsonSerializerSettings)
   at Newtonsoft.Json.JsonConvert.DeserializeObject[T](String )
   at Program.<>c__DisplayClass0_0.<<Main>$>b__0(String[] addlDirectories, String[] addlExeExclusionWords, String sunshineConfigLocation, Boolean forceUpdate, Boolean removeUninstalled)
   at System.CommandLine.Handler.<>c__DisplayClass6_0`5.<SetHandler>b__0(InvocationContext context)
   at System.CommandLine.Invocation.AnonymousCommandHandler.Invoke(InvocationContext)
   at System.CommandLine.Invocation.InvocationPipeline.<>c__DisplayClass4_0.<<BuildInvocationChain>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass17_0.<<UseParseErrorReporting>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass12_0.<<UseHelp>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass22_0.<<UseVersionOption>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass19_0.<<UseTypoCorrections>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<UseSuggestDirective>b__18_0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass16_0.<<UseParseDirective>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<RegisterWithDotnetSuggest>b__5_0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass8_0.<<UseExceptionHandler>b__0>d.MoveNext()

[GaMeRaM]

Sounds like the solution is in the pipeline but I get a similar issue with 1.9.2 , related to the env key it seems:

Unhandled exception: Newtonsoft.Json.JsonSerializationException: Unable to find a constructor to use for type SunshineGameFinder.SunshineConfig. A class should either have a default constructor, one constructor with arguments or a constructor marked with the JsonConstructor attribute. Path 'env', line 2, position 10.
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateNewObject(JsonReader, JsonObjectContract, JsonProperty , JsonProperty , String , Boolean& )
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader , Type, JsonContract, JsonProperty, JsonContainerContract, JsonProperty, Object)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader , Type, JsonContract, JsonProperty, JsonContainerContract, JsonProperty, Object)
   at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader , Type, Boolean)
   at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader , Type)
   at Newtonsoft.Json.JsonSerializer.Deserialize(JsonReader , Type)
   at Newtonsoft.Json.JsonConvert.DeserializeObject(String , Type, JsonSerializerSettings)
   at Newtonsoft.Json.JsonConvert.DeserializeObject[T](String , JsonSerializerSettings)
   at Newtonsoft.Json.JsonConvert.DeserializeObject[T](String )
   at Program.<>c__DisplayClass0_0.<<Main>$>b__0(String[] addlDirectories, String[] addlExeExclusionWords, String sunshineConfigLocation, Boolean forceUpdate, Boolean removeUninstalled)
   at System.CommandLine.Handler.<>c__DisplayClass6_0`5.<SetHandler>b__0(InvocationContext context)
   at System.CommandLine.Invocation.AnonymousCommandHandler.Invoke(InvocationContext)
   at System.CommandLine.Invocation.InvocationPipeline.<>c__DisplayClass4_0.<<BuildInvocationChain>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass17_0.<<UseParseErrorReporting>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass12_0.<<UseHelp>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass22_0.<<UseVersionOption>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass19_0.<<UseTypoCorrections>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<UseSuggestDirective>b__18_0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass16_0.<<UseParseDirective>b__0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c.<<RegisterWithDotnetSuggest>b__5_0>d.MoveNext()
--- End of stack trace from previous location ---
   at System.CommandLine.Builder.CommandLineBuilderExtensions.<>c__DisplayClass8_0.<<UseExceptionHandler>b__0>d.MoveNext()

Can you please send your apps.json so I can test the updated code?

[JMTK]

Fixed in 1.10.0