Feature/support php8 only #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
That said, maybe it's a good idea to release this as v3.0 instead of v2.0, to ensure systems using this module don't get broken. |
|
I understand. 7.4 will reach EOL this month I believe.. Would be great to have atleast 7.4 and up as the last 7 release and then push for a 8+ branch and keep development there. That way clients relying on php7 can always stick to the older branch/release. Love semver :) |
- constructor property promotion - match instead of switch/case - dropped superfluous docblocks
fruitl00p
force-pushed
the
feature/support-php8-only
branch
from
0dbc75f
to
ec0fce8
Compare
|
@JKetelaar any possible update on this PR (and/or the Guzzle update to atleast get Drupal10 compatibility) |
|
Hi there - thanks for the headsup. I'll merge this PR, thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the last and (currently) final MR to drop PHP7 entirely.
I suspect you'd like to release an intermediate PHP7 supporting release first and then bump the semver major to only support php8+ in the future.