Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8 support #37

Closed
fruitl00p opened this issue Nov 17, 2022 · 3 comments
Closed

PHP8 support #37

fruitl00p opened this issue Nov 17, 2022 · 3 comments

Comments

@fruitl00p
Copy link
Contributor

I've gone ahead and created several merge requests to bring the project up to par (or atleast support PHP8)

I've created them in succesion which shoul alleviate the review burden.

The project should support PHP8 out of the box (mostly) but the first MR 'codifies' this. ( #34 )
Next i've gone ahead and updated various files and dependencies to utilize the PHP of today ( #35 )
This would be the last 'status' that would support PHP7.
Finally the last MR should drop PHP7 support and utilize the modern tricks one can now do with PHP. ( #36 )

Hope you can merge these as we'd like to keep using this library with PHP8

@JKetelaar
Copy link
Owner

Hi @fruitl00p - thanks for the awesome work, this is highly appreciated!

How do you feel about releasing v3.0 with the changes for PHP 8+ support? Instead of doing this within v2.x.

@fruitl00p
Copy link
Contributor Author

That's up to you primarily and would follow several nicely. It also leaves the ability for older clients to keep churning on older PHP

@JKetelaar
Copy link
Owner

PHP 8 is now available with version 2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants