Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build for improved debugability. #184

Merged
merged 7 commits into from
Jan 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/build-4.x.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
php-versions: ["8.0", "8.1", "8.2"]
php-versions: ["8.1", "8.2", "8.3"]

name: PHP ${{ matrix.php-versions }}

Expand Down Expand Up @@ -66,7 +66,11 @@ jobs:
- name: composer install
run: |
cd $GITHUB_WORKSPACE/build_dir
for D in */; do (cd $D; composer install) done
for D in */; do
echo "::group::composer install under $D"
(cd $D; composer install)
echo "::endgroup"
done

- name: line endings
run: $SCRIPT_DIR/line_endings.sh $GITHUB_WORKSPACE
Expand Down
20 changes: 16 additions & 4 deletions .scripts/tester
Original file line number Diff line number Diff line change
@@ -1,13 +1,25 @@
#!/bin/sh
#!/bin/bash
export SYMFONY_DEPRECATIONS_HELPER=disabled
FAIL=0
FAILED=()
for D in */; do
cd $D
echo "Operating on $D"
echo "::group::Testing $D"
cd $D
composer test
if [ $? -ne 0 ]; then
FAIL=1
FAILED+=($D)
fi
cd ..
cd ..
echo "::endgroup"
done

echo "::group::Summary"
if [ ${#FAILED[@]} -gt 0 ] ; then
echo "Failed tests: ${FAILED[@]}"
else
echo "All tests passed!"
fi
echo "::endgroup"

exit $FAIL
1 change: 1 addition & 0 deletions Homarus/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@
],
"test": [
"@check",
"@putenv SYMFONY_PHPUNIT_REQUIRE=\"nikic/php-parser:^4.13\"",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, the separate PHPUnit installation was installing nikic/php-parser:5.4.0; however, 5 introduced typehints. This had the effect of causing errors when running tests with code coverage, so let's keep it to the same (major) version, for now.

"bin/phpunit"
]
},
Expand Down
Loading