Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build for improved debugability. #184

Merged
merged 7 commits into from
Jan 7, 2025
Merged

Conversation

adam-vessey
Copy link
Collaborator

GitHub Issue: (link)

  • Other Relevant Links (Google Groups discussion, related pull requests, Release pull requests, etc.)

What does this Pull Request do?

A brief description of what the intended result of the PR will be and/or what problem it solves.

What's new?

A in-depth description of the changes made by this PR. Technical details and possible side effects.

  • Changes x feature to such that y
  • Added x
  • Removed y
  • Does this change require documentation to be updated?
  • Does this change add any new dependencies?
  • Does this change require any other modifications to be made to the repository (i.e. Regeneration activity, etc.)?
  • Could this change impact execution of existing code?

How should this be tested?

A description of what steps someone could take to:

  • Reproduce the problem you are fixing (if applicable)
  • Test that the Pull Request does what is intended.
  • Please be as detailed as possible.
  • Good testing instructions help get your PR completed faster.

Additional Notes:

Any additional information that you think would be helpful when reviewing this PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers

@@ -64,6 +64,7 @@
],
"test": [
"@check",
"@putenv SYMFONY_PHPUNIT_REQUIRE=\"nikic/php-parser:^4.13\"",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this, the separate PHPUnit installation was installing nikic/php-parser:5.4.0; however, 5 introduced typehints. This had the effect of causing errors when running tests with code coverage, so let's keep it to the same (major) version, for now.

@adam-vessey adam-vessey marked this pull request as ready for review January 7, 2025 14:45
@seth-shaw-asu seth-shaw-asu merged commit a0b33d3 into 4.x Jan 7, 2025
3 checks passed
@adam-vessey adam-vessey deleted the adam-vessey-patch-1 branch January 7, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants