Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug which causes the outbound governor to loose track of an outbound connection. This can prevent outbound governor to notice a demotion, and thus prevent it to re-establish a connection. This can happen only in specific conditions, with rather low frequency, however high enough to be observed by some SPOs.
outbound-governor: made asyncDemotion recognition more robust
The Outbound Governor might not see
PeerCooling
state, sinceSTM
doesn't guarantee that every update is visible.asyncDemotion
has to be robust enough to acceptPeerCold
without seeingPeerCooling
before.peer-state-actions: made closePeerConnection more robust
Carefully update the state to
PeerCooling
so that we don't overwritePeerCold
, refChecklist