Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should also have a test that checks that a peer is added to the established set #4766

Open
bolt12 opened this issue Jan 8, 2024 · 1 comment · Fixed by #4757
Open
Labels
connection-manager Issues / PRs related to connection-manager good first issue Good for newcomers outbound-governor Issues / PRs related to outbound-governor testing

Comments

@bolt12
Copy link
Contributor

bolt12 commented Jan 8, 2024

That we should/could check that whenever there's a Unnegotiated -> Negotiated Outbound transition the peer is eventually added to the established set

Originally posted by @bolt12 in #4757 (comment)

@bolt12 bolt12 added good first issue Good for newcomers testing connection-manager Issues / PRs related to connection-manager labels Jan 8, 2024
@coot
Copy link
Contributor

coot commented Jan 22, 2024

This is related to the bug fixed in #4748.

@coot coot linked a pull request Jan 22, 2024 that will close this issue
@coot coot added the outbound-governor Issues / PRs related to outbound-governor label May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connection-manager Issues / PRs related to connection-manager good first issue Good for newcomers outbound-governor Issues / PRs related to outbound-governor testing
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants