Refactored DiffusionScript #4004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
approved these changes
Oct 18, 2022
ouroboros-network/test/Test/Ouroboros/Network/Testnet/Simulation/Node.hs
Outdated
Show resolved
Hide resolved
bolt12
commented
Oct 19, 2022
ouroboros-network/test/Test/Ouroboros/Network/Testnet/Simulation/Node.hs
Outdated
Show resolved
Hide resolved
|
bors merge |
|
Timed out. |
|
bors merge |
|
Build failed: |
|
There was an unrelated test failure which I recorded in #4092. |
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Oct 21, 2022
4086: Add diffusion tests r=coot a=coot # Description Added new tests: * `prop_diffusion_target_active_local_below` - a copy of a similar test of the outbound governor * `prop_diffusion_async_demotions` - a test which makes sure that if `PeerStateActions` report `HotToCold` demotion, the outbound governor will remove the peer from the active set. * `unit_diffusion_async_demotions` - a special case of the previous test, which reproduces the bug reported in #4064 The pull request refactors usage of traces by the diffusion tests, which make it easier to get debugging output. The pull request modifies `keyedTimeout` so that it does not ignores events which did not timeout till the end of the simulation. Requires #4004 to be merged first. - connection-manager: haddocks, code style & typos - net-sim: exported WithAddr - net-sim: protect from establishing connection twice - net-sim: code cleanup - diffusion-sim: added prop_diffusion_target_active_local_above - diffusion-sim: reproduce peer-state-action bug - diffusion-sim: set keep-alive and ping-pong intervals - diffusion-sim: refactor how a tracer is used - diffusion-sim: fix ping pong time limits - diffusion-sim: cleanup tracers - diffusion-sim: added debugTracer - peer-state-actions: export traces - signals: do not ignore tail in keyedTimeout - diffusion-sim: added async demotion test - diffusion-sim: refactor test cases Co-authored-by: Marcin Szamotulski <coot@coot.me>
This was referenced Oct 28, 2022
iohk-bors bot
added a commit
that referenced
this pull request
Nov 9, 2022
4120: Cherry picked network changes for cardano-node-1.35.5 release r=coot a=coot This cherry-picked patches from the following PRs: * #3794 * #3844 * #3785 * #3904 * #3915 * #3852 * #3970 * #3979 * #4015 * #4067 * #4004 * #4086 * #4113 * #4106 * #4127 * #4103 Also cherry-picked almost all the commits which modify GitHub actions: * 18c5244 Run GitHub Actions on pull requests * 3adf5a9 Use newer version of io-sim * ee9b7a6 Fix GH Actions Windows CI: switch from pkgconf to pkg-config * e6cf074 github-actions: use `ubuntu-latest` * 9a8b959 Updated versions of github actions * fc8f8f0 Fix GH Actions Windows CI caching * 7f07c40 Windows Github Actions now use MSYS2 * b21a7ce Fix chocolatey CI error * #4134 TODO: * [x] bump versions of packages * [x] input-output-hk/cardano-haskell-packages#84 Co-authored-by: Mark Tullsen <tullsen@galois.com> Co-authored-by: Marcin Szamotulski <coot@coot.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #3905
Checklist
interface-CHANGELOG.mdinterface-CHANGELOG.md