Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outbound governor does not remove a hot peer when mux errors #4064

Closed
Tracked by #3888
coot opened this issue Oct 7, 2022 · 0 comments · Fixed by #4067
Closed
Tracked by #3888

Outbound governor does not remove a hot peer when mux errors #4064

coot opened this issue Oct 7, 2022 · 0 comments · Fixed by #4067
Labels
bug Something isn't working outbound-governor Issues / PRs related to outbound-governor

Comments

@coot
Copy link
Contributor

coot commented Oct 7, 2022

No description provided.

@coot coot added bug Something isn't working networking outbound-governor Issues / PRs related to outbound-governor labels Oct 7, 2022
@iohk-bors iohk-bors bot closed this as completed in b995908 Oct 14, 2022
coot added a commit that referenced this issue Oct 19, 2022
coot added a commit that referenced this issue Oct 19, 2022
@coot coot mentioned this issue Oct 19, 2022
9 tasks
coot added a commit that referenced this issue Oct 20, 2022
iohk-bors bot added a commit that referenced this issue Oct 21, 2022
4086: Add diffusion tests r=coot a=coot

# Description

Added new tests:

* `prop_diffusion_target_active_local_below` - a copy of a similar test of the
  outbound governor
* `prop_diffusion_async_demotions` - a test which makes sure that if
  `PeerStateActions` report `HotToCold` demotion, the outbound governor will
  remove the peer from the active set.
* `unit_diffusion_async_demotions` - a special case of the previous test, which
  reproduces the bug reported in #4064

The pull request refactors usage of traces by the diffusion tests, which
make it easier to get debugging output.

The pull request modifies `keyedTimeout` so that it does not ignores events
which did not timeout till the end of the simulation.

Requires #4004 to be merged first.

- connection-manager: haddocks, code style & typos
- net-sim: exported WithAddr
- net-sim: protect from establishing connection twice
- net-sim: code cleanup
- diffusion-sim: added prop_diffusion_target_active_local_above
- diffusion-sim: reproduce peer-state-action bug
- diffusion-sim: set keep-alive and ping-pong intervals
- diffusion-sim: refactor how a tracer is used
- diffusion-sim: fix ping pong time limits
- diffusion-sim: cleanup tracers
- diffusion-sim: added debugTracer
- peer-state-actions: export traces
- signals: do not ignore tail in keyedTimeout
- diffusion-sim: added async demotion test
- diffusion-sim: refactor test cases



Co-authored-by: Marcin Szamotulski <coot@coot.me>
coot added a commit that referenced this issue Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working outbound-governor Issues / PRs related to outbound-governor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant