Update ledger #3690
Merged
Update ledger #3690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
requested review from
coot,
newhoggy,
a team,
nfrisby,
dnadales,
bolt12 and
EncodePanda
as code owners
nc6
approved these changes
Apr 4, 2022
|
Though note also #3686 |
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Apr 5, 2022
3690: Update ledger r=lehins a=lehins Brings ledger and consensus in sync. Also took care of a `TODO`. Updated GithubActions CI to account for secp256k1, except for Windows, since that one will be solved shortly in base, after which we can adopt the approach here in consensus and in cardano-node Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"2 of 4 required status checks have not succeeded: 1 failing.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
|
Rebasing on top of/merging master should fix the bors failure (as of #3687, which fixed the GH Windows job failure due to missing libsecp256k1). |
lehins
force-pushed
the
lehins/update-ledger
branch
from
16e9c4f
to
bbc7a50
Compare
|
@amesgen Thank you for letting me know. It's done. Will wait now for CI to turn green 😄 |
|
@lehins can you cleanup/refine the PR description regarding secp256k1 and Windows? The PR descriptions in this repo end up in the merge commits. Thanks much for the PR! |
That's great, didn't know that. Cleaned up. |
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings ledger and consensus in sync.
Also took care of a
TODO: relax constraint fromApplicativetoFunctorUpdated GithubActions CI to pin secp256k1