-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ledger #3690
Update ledger #3690
Conversation
Though note also #3686 |
bors merge |
3690: Update ledger r=lehins a=lehins Brings ledger and consensus in sync. Also took care of a `TODO`. Updated GithubActions CI to account for secp256k1, except for Windows, since that one will be solved shortly in base, after which we can adopt the approach here in consensus and in cardano-node Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"2 of 4 required status checks have not succeeded: 1 failing.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
Rebasing on top of/merging master should fix the bors failure (as of #3687, which fixed the GH Windows job failure due to missing libsecp256k1). |
16e9c4f
to
bbc7a50
Compare
@amesgen Thank you for letting me know. It's done. Will wait now for CI to turn green 😄 |
@lehins can you cleanup/refine the PR description regarding secp256k1 and Windows? The PR descriptions in this repo end up in the merge commits. Thanks much for the PR! |
That's great, didn't know that. Cleaned up. |
bors merge |
Brings ledger and consensus in sync.
Also took care of a
TODO
: relax constraint fromApplicative
toFunctor
Updated GithubActions CI to pin secp256k1