Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install libsecp256k1 on Windows #3687

Merged
merged 3 commits into from
Apr 5, 2022
Merged

Conversation

amesgen
Copy link
Member

@amesgen amesgen commented Apr 4, 2022

Closes #3678, alternative to #3683

This installs the prebuilt libsecp256k1 DLL built via input-output-hk/haskell.nix#1424.

@hamishmack
Copy link
Contributor

I think we might also want the extra echo commands from libsodium install step and the sed to convert to windows path before adding to GITHUB_PATH.

        export PKG_CONFIG_PATH="$PKG_CONFIG_PATH;$(readlink -f secp256k1/lib/pkgconfig)"
        echo "PKG_CONFIG_PATH=$PKG_CONFIG_PATH"
        echo "PKG_CONFIG_PATH=$PKG_CONFIG_PATH" >> $GITHUB_ENV
        export SECP256K1_PATH="$(readlink -f secp256k1/bin | sed 's|^/d|D:|g' | tr / '\\')"
        echo "SECP256K1_PATH=$SECP256K1_PATH"
        echo "$SECP256K1_PATH" >> $GITHUB_PATH

hamishmack added a commit to input-output-hk/haskell.nix that referenced this pull request Apr 4, 2022
hamishmack added a commit to input-output-hk/haskell.nix that referenced this pull request Apr 4, 2022
@hamishmack
Copy link
Contributor

I tried using temp dir for libsecp256k1 like libsodium does and that did not seem to help. I put -v3 on cabal and it did not really reveal much (but it did look like pkg-config was running and not finding the library at all).

Then I tried making the paths in PKG_CONFIG_PATH into windows paths and that seems to have fixed the issue!

It's not finished building and running the tests yet, but here is a PR to update this PR #3693.

hamishmack added a commit to input-output-hk/haskell.nix that referenced this pull request Apr 5, 2022
@amesgen amesgen marked this pull request as ready for review April 5, 2022 08:15
@amesgen amesgen requested review from coot, newhoggy and a team as code owners April 5, 2022 08:15
Co-authored-by: Hamish Mackenzie <Hamish.K.Mackenzie@gmail.com>
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a bunch for the fix!

@coot
Copy link
Contributor

coot commented Apr 5, 2022

bors merge

iohk-bors bot added a commit that referenced this pull request Apr 5, 2022
3687: Install libsecp256k1 on Windows  r=coot a=amesgen

Closes #3678, alternative to #3683

This installs the prebuilt libsecp256k1 DLL built via input-output-hk/haskell.nix#1424.

Co-authored-by: Alexander Esgen <alexander.esgen@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 5, 2022

This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried.

Additional information:

{"message":"2 of 4 required status checks are in progress.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

@amesgen
Copy link
Member Author

amesgen commented Apr 5, 2022

I raised this error on slack.

coot and others added 2 commits April 5, 2022 15:30
3694: Update bors.toml file r=coot a=coot



Co-authored-by: Marcin Szamotulski <coot@coot.me>
@amesgen
Copy link
Member Author

amesgen commented Apr 5, 2022

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 5, 2022

@iohk-bors iohk-bors bot merged commit e850e30 into master Apr 5, 2022
@iohk-bors iohk-bors bot deleted the amesgen/windows-secp256k1 branch April 5, 2022 17:39
@amesgen amesgen mentioned this pull request Apr 5, 2022
iohk-bors bot added a commit to IntersectMBO/cardano-node that referenced this pull request Apr 6, 2022
3767: Install secp256k1 on Windows in Github Actions r=newhoggy a=newhoggy

Change taken from IntersectMBO/ouroboros-network#3687

Co-authored-by: John Ky <john.ky@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install libsecp256k1 on Windows in GH actions.
3 participants