-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install libsecp256k1 on Windows #3687
Conversation
I think we might also want the extra echo commands from libsodium install step and the
|
I tried using temp dir for Then I tried making the paths in It's not finished building and running the tests yet, but here is a PR to update this PR #3693. |
Co-authored-by: Hamish Mackenzie <Hamish.K.Mackenzie@gmail.com>
1f82260
to
81e06d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a bunch for the fix!
bors merge |
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"2 of 4 required status checks are in progress.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
I raised this error on slack. |
bors r+ |
3767: Install secp256k1 on Windows in Github Actions r=newhoggy a=newhoggy Change taken from IntersectMBO/ouroboros-network#3687 Co-authored-by: John Ky <john.ky@iohk.io>
Closes #3678, alternative to #3683
This installs the prebuilt libsecp256k1 DLL built via input-output-hk/haskell.nix#1424.