Skip to content

Commit

Permalink
Merge #3743
Browse files Browse the repository at this point in the history
3743: ChainDB q-s-m test: workaround for flaky `GetIsValid` discrepancy r=amesgen a=amesgen

This resolves the flakiness due to #3689 until we have time to properly fix this.

To test this, observe that
```
cabal run test-storage -- -p 'ChainDB q-s-m' --quickcheck-replay=455411
```
fails before this change, but will succeed after.

Co-authored-by: Alexander Esgen <alexander.esgen@iohk.io>
  • Loading branch information
iohk-bors[bot] and amesgen authored May 13, 2022
2 parents 9dca6c9 + ed8adea commit 0112e6b
Showing 1 changed file with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,13 @@ instance Eq IsValidResult where
(Just x1, Just x2) -> x1 == x2
(Nothing, Nothing) -> True
(Nothing, Just _) -> True
(Just _, Nothing) -> False
(Just _, Nothing) ->
-- TODO Right now, the model implementation sometimes
-- incorrectly returns Nothing while the real one returns
-- Just. To reduce test flakiness for now, we deviate from
-- the comments above, but we should try to change this back
-- to False in the future, cf. #3689.
True

{-------------------------------------------------------------------------------
Max clock skew
Expand Down

0 comments on commit 0112e6b

Please sign in to comment.