ChainDB q-s-m test: workaround for flaky GetIsValid discrepancy

IntersectMBO · May 12, 2022 · ed8adea · ed8adea
1 parent d3eaedd
commit ed8adea
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/ouroboros-consensus-test/test-storage/Test/Ouroboros/Storage/ChainDB/StateMachine.hs b/ouroboros-consensus-test/test-storage/Test/Ouroboros/Storage/ChainDB/StateMachine.hs
@@ -526,7 +526,13 @@ instance Eq IsValidResult where
         (Just x1, Just x2) -> x1 == x2
         (Nothing, Nothing) -> True
         (Nothing, Just _)  -> True
-        (Just _,  Nothing) -> False
+        (Just _,  Nothing) ->
+          -- TODO Right now, the model implementation sometimes
+          -- incorrectly returns Nothing while the real one returns
+          -- Just. To reduce test flakiness for now, we deviate from
+          -- the comments above, but we should try to change this back
+          -- to False in the future, cf. #3689.
+          True
 
 {-------------------------------------------------------------------------------
   Max clock skew