-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1527 conway offchain voting #1562
Conversation
a28398e
to
b69e7b7
Compare
65e32b7
to
96720a3
Compare
edf95e5
to
faa7cdf
Compare
06c59af
to
e6d33c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some remaining issues. Also I tested this on sanchonet and even though there are entries in voting_anchor
, there are no entries in off_chain_vote_data
or off_chain_vote_fetch_error
.
A separate issue on sanchonet when off_chain_vote_data was inserted
Possibly the json sql type can't be empty |
ae2a9c4
to
90176da
Compare
90176da
to
7ae6f39
Compare
Could you add a new Changelog entry under |
{-# LANGUAGE OverloadedStrings #-} | ||
{-# LANGUAGE Rank2Types #-} | ||
{-# LANGUAGE ScopedTypeVariables #-} | ||
{-# LANGUAGE NoImplicitPrelude #-} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I notice we have a lot of modules using both Prelude and Cardano.Prelude. Should we use this pattern everywhere (NoImplicitPrelude
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could set it globally in the cabal file? unless we need Prelude
for some reason
fe75715
to
489ee3d
Compare
|
||
OffChainAnchorFetchError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 2 tables that are deleted, should be deleted also from the sql files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having a bit of trouble with the rebasing!! just reran a migration but it's doing weird things it seems
80e6a93
to
1a4a17d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
Add OffChain Voting Anchor utilising existing offchain code for pools
this fixes #1527
Checklist
fourmolu
on version 0.10.1.0 (which can be run withscripts/fourmolize.sh
)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.