Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offchain Governance Metadata #1617

Closed
Cmdv opened this issue Feb 5, 2024 · 1 comment
Closed

Offchain Governance Metadata #1617

Cmdv opened this issue Feb 5, 2024 · 1 comment
Labels
conway Conway integration blockers or reauested feautures

Comments

@Cmdv
Copy link
Contributor

Cmdv commented Feb 5, 2024

Currently we are storing the whole of the json into the Database inside of OffChainVoteDataJson / offchainvote table
which happens around here:

insert :: (MonadBaseControl IO m, MonadIO m) => OffChainPoolResult -> ReaderT SqlBackend m ()
insert = \case
OffChainPoolResultMetadata md -> void $ DB.insertCheckOffChainPoolData md
OffChainPoolResultError fe -> void $ DB.insertCheckOffChainPoolFetchError fe

current functionality was introduced in this PR

TLDR currently we:

  1. fetch offchain metadata
  2. put it into DB inside OffChainVoteDataJson

What we'd ideally like is:

  1. fech offchain metadata
  2. parse metadata
  3. put parsed metadata into a new table with same structure as the parsed type
  4. link newly created row id in OffChainVoteDataJson which is currently of the typeText

We can get the expected structure from cardano-foundation/CIPs#632 once it is merged and finalised.

@Cmdv Cmdv added the conway Conway integration blockers or reauested feautures label Feb 5, 2024
@kderme
Copy link
Contributor

kderme commented Mar 19, 2024

An initial implementation of this is done at sancho-4-1-0

@kderme kderme closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conway Conway integration blockers or reauested feautures
Projects
Status: Done
Development

No branches or pull requests

2 participants