Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4L2 controls fixup #91

Merged
merged 1 commit into from
May 10, 2022
Merged

V4L2 controls fixup #91

merged 1 commit into from
May 10, 2022

Conversation

xzhangxa
Copy link
Collaborator

@xzhangxa xzhangxa commented Mar 24, 2022

  • No laser controls for color sensor;
  • Set control values to their default when initialization;
  • Follow doc, default manual laser power value changed from 240 to 150;
  • No any control for IMU.

The issue that this PR tries to solve:

  • When D457 first power up, some values reading from FW are not the same as their default values in doc
    • Color sensor's exposure_time_absolute is 0, though in document min is 1 and default is 1660. (maybe because auto_exposure is on so this is irrelevant, though depth sensor's exposure_time_absolute is at the default 330 and auto_exposure is on too)
    • Color sensor's analogue_gain is 0, not the default 64.
    • Manual laser power value is 150, not default 240.
  • Without power off, the control values will be consistent from boot to boot, so if the user changed some control value once, and at next boot the v4l2 interface will still show the default value, not the real value in FW.

@xzhangxa xzhangxa requested review from shikundi and qingwuzh March 24, 2022 08:04
@xzhangxa xzhangxa marked this pull request as ready for review March 29, 2022 15:45
@xzhangxa xzhangxa changed the base branch from JetPack_4.6.1_baseline to master April 7, 2022 09:02
@xzhangxa
Copy link
Collaborator Author

xzhangxa commented Apr 7, 2022

  • Update manual laser power value default from 240 to 150, according to email exchange.
  • Update PR target branch to master.

@xzhangxa
Copy link
Collaborator Author

Leave only control changes only, move HWMC changes to another PR. @ev-mp

@xzhangxa xzhangxa force-pushed the ctrls branch 2 times, most recently from 262eac2 to 0bcf649 Compare April 25, 2022 09:00
@xzhangxa xzhangxa mentioned this pull request Apr 28, 2022
- No laser controls for color sensor;
- Set control values to their default when initialization;
- Follow doc, default manual laser power value changed from 240 to 150;
- No any control for IMU.

Signed-off-by: Xin Zhang <xin.x.zhang@intel.com>
@ev-mp ev-mp merged commit 1bc63b5 into IntelRealSense:master May 10, 2022
@xzhangxa xzhangxa deleted the ctrls branch October 13, 2022 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants