Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HWMC code cleanup #102

Closed
wants to merge 1 commit into from
Closed

Conversation

xzhangxa
Copy link
Collaborator

  • Remove some not needed HWMC controls, driver should just pass the cmd
    without knowing the logic, the logic should be handled in user space;
  • Refactor HWMC and log control code.

This is split from the original ctrls fix #91 so it's based on that PR.

@dmipx
Copy link
Contributor

dmipx commented May 26, 2022

I think it need to be rebased and these patch file names should be reenumerated

- Remove some not needed HWMC controls, driver should just pass the cmd
  without knowing the logic, the logic should be handled in user space;
- Refactor HWMC and log control code.

Signed-off-by: Xin Zhang <xin.x.zhang@intel.com>
@xzhangxa
Copy link
Collaborator Author

I think it need to be rebased and these patch file names should be reenumerated

Rebased, using 0062 to avoid conflict again with the two new PRs of 0060.

@remibettan
Copy link
Contributor

The aim of this change is to restore the hwm mechanism so that it would work with this driver, the same way as it works with USB driver.
The set_xu method used for hwm should get a buffer of 1024 bytes (now it needs 1028 bytes).
The get_xu method used for hwm should return a buffer that would start with the opcode, and then the answer buffer (without the input command buffer.

@xzhangxa xzhangxa closed this Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants