Fix issue #75: Benchmarks silently execute stock version if scikit-learn-intelex is not installed #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix the log isn't displayed in bench.py, because bench.py is running via subprocess, so the log config set in runner.py has no effect in bench.py, and the log config in bench.py follows the default strategy (log_level=WARNING, stream=stderr), so when scikit-learn-intelex is not installed, the info log can't be displayed, furthermore, all other info logs in bench.py can't be displayed either. This fix does the following change: 1. Set a log config in bench.py (log_level=INFO, stream=stderr). 2. Add return_code in the return value of utils.read_output_from_command() to identify if there is any error in subprocess. 3. In runner.py, if no error occured, the log from subprocess in stderr will be printed, otherwise is_success will be set to False and the error message will be displayed through a warning log. Fixes IntelPython#75 Co-authored-by: Wu, Zihan <zihan.wu@intel.com> Signed-off-by: Deng, Lulin <lulin.deng@intel.com> Signed-off-by: Zhou, Shuangpeng <shuangpeng.zhou@intel.com> Signed-off-by: Xu, Yanyue <yanyue.xu@intel.com>
|
@Alexsandruss are we going to integrate this into main branch or we have a fix on your branch? |
|
Benchmarks output warning if sklearnex patching has failed starting from refactoring (#133). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix log not displayed in bench.py
Before this fix the log isn't displayed in bench.py, because bench.py is
running via subprocess, so the log config set in runner.py has no effect in
bench.py, and the log config in bench.py follows the default strategy
(log_level=WARNING, stream=stderr), so when scikit-learn-intelex is not
installed, the info log can't be displayed, furthermore, all other info logs
in bench.py can't be displayed either.
This fix does the following change:
Fixes #75
Co-authored-by: Wu, Zihan zihan.wu@intel.com
Signed-off-by: Deng, Lulin lulin.deng@intel.com
Signed-off-by: Zhou, Shuangpeng shuangpeng.zhou@intel.com
Signed-off-by: Xu, Yanyue yanyue.xu@intel.com