Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks silently execute stock version if scikit-learn-intelex is not installed #75

Closed
michael-smirnov opened this issue Jun 29, 2021 · 1 comment · Fixed by #133
Closed

Benchmarks silently execute stock version if scikit-learn-intelex is not installed #75

michael-smirnov opened this issue Jun 29, 2021 · 1 comment · Fixed by #133
Labels
bug Something isn't working

Comments

@michael-smirnov
Copy link
Contributor

If I try to run benchmarks with the command like

python runner.py --configs configs/skl_xpu_config.json

it should run a patched version of scikit-learn algorithms. However, if scikit-learn-intelex package is not installed, benchmarks cannot be patched and should print an error or warning.

I cannot see the message in https://github.com/IntelPython/scikit-learn_bench/blob/master/bench.py#L204 for some reason.
@michael-smirnov michael-smirnov added the bug Something isn't working label Jun 29, 2021
@lulin789
Copy link

SKL_Bench_Team1 working on this issue

hjzin added a commit to lulin789/scikit-learn_bench that referenced this issue Apr 27, 2023
@hjzin @zhwuwuwu
Fix log not displayed in bench.py
7e6a2e3 
Before this fix the log isn't displayed in bench.py, because bench.py is
running via subprocess, so the log config set in runner.py has no effect in
bench.py, and the log config in bench.py follows the default strategy
(log_level=WARNING, stream=stderr), so when scikit-learn-intelex is not
installed, the info log can't be displayed, furthermore, all other info logs
in bench.py can't be displayed either.

This fix does the following change:
1. Set a log config in bench.py (log_level=INFO, stream=stderr).
2. Add return_code in the return value of utils.read_output_from_command() to identify if there is any error in subprocess.
3. In runner.py, if no error occured, the log from subprocess in stderr will be printed, otherwise is_success will be set to False and the error message will be displayed through a warning log.

Fixes IntelPython#75

Co-authored-by: Wu, Zihan <zihan.wu@intel.com>
Signed-off-by: Deng, Lulin <lulin.deng@intel.com>
Signed-off-by: Zhou, Shuangpeng <shuangpeng.zhou@intel.com>
Signed-off-by: Xu, Yanyue <yanyue.xu@intel.com>
@lulin789 lulin789 mentioned this issue Apr 28, 2023
Closed
@Alexsandruss Alexsandruss mentioned this issue May 17, 2023
Merged
@Alexsandruss Alexsandruss linked a pull request May 17, 2023 that will close this issue
Refactoring of benchmarks #133
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@michael-smirnov @PetrovKP @lulin789