Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hrs driver changes #876

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Conversation

yehoshuapw
Copy link
Contributor

changed low level driver for HRS3300 to return uint32_t values (since it gives 18 bit values)
and changed hidden uint16_t to float convert, to a static_cast.

supersedes #875

thanks for all the great work!

Copy link
Contributor

@Riksu9000 Riksu9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The resolution is limited to 16 bits, which is why this hasn't been an issue, but it should be fixed so there won't be any issues in the future.

@JF002 JF002 added this to the 1.9.0 milestone Jan 19, 2022
@JF002 JF002 merged commit 9e9010c into InfiniTimeOrg:develop Jan 26, 2022
@JF002
Copy link
Collaborator

JF002 commented Jan 26, 2022

@yehoshuapw Thanks, and congratulations for your first contribution to the project!

@yehoshuapw yehoshuapw deleted the hrs-driver-changes branch January 27, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants