Remove unused bits in Hrs3300::ReadAls, ReadHrs #875
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since both functions `Hrs3300::ReadHrs`, `Hrs3300::ReadAls` return `uint16_t`: * removed extra 2 bits (at position 16,17) in HRS, which will be thrown out * removed unneeded checks of garbage bits in ALS, since they too will be thrown out.
|
So after a discussion, it seems that the low level driver should not cut off the extra 2 bits, and that can (and perhaps should for memory issues) be done at a higher level. Therefore, I am closing this PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thanks a lot! great work making this and continuing to make it.
(commit message:)
Since both functions
Hrs3300::ReadHrs,Hrs3300::ReadAlsreturnuint16_t:out
thrown out.
I have a bit more doubts about the second change (not doing
& 0x3f), since while it still does happen, it does not clearly say that the MSB of the H register is trash. (since for the uint16_t all the 3 MSB are trash)