Split declaration and implementation of GetSymbol #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build checks have not completed. Possible reasons for this are:
|
FintasticMan
approved these changes
Jan 15, 2024
NeroBurner
reviewed
Jan 16, 2024
ljahn
force-pushed
the
fixWeatherSymbols
branch
from
5f63998 to
d6ff539
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was adding the new
SimpleWeatherServiceto my Star Trek Watchface, the linker got confused about multiple implementations ofPinetime::Applications::Screens::Symbols::GetSymbol.Including
WeatherSymbols.hin two different files declared and implemented it two times.This fixes that problem, by splitting the declaration and implementation of said function.