Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary:
The current implementation of
response.json()
from therequests
module involves time-consuming charset detection, particularly problematic when handling a large number of requests. (For more details, see this Stack Overflow discussion: Stack Overflow - Performance Issues When Formatting Using JSON).This pull request introduces an enhancement to the
dicomweb-client
module, specifying the character set and bypass charset detection. This improvement can significantly boost performance. This is compatibledwith therequests
module (https://docs.python-requests.org/en/latest/user/quickstart/#response-content)In the specific case of DICOMWEB, the presence of the UTF-8 charset in every response is guaranteed, as dictated by the DICOM standard. More information about this requirement can be found in the DICOM standard documentation: DICOM Standard - Section F.2.
Changes:
dicomweb-client
module, specifying the character set.Testing:
All tests have passed successfully.
Notes:
Thank you for your attention to this matter.