Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated numpy method calls #86

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Update deprecated numpy method calls #86

merged 1 commit into from
Sep 5, 2023

Conversation

cgorman
Copy link
Collaborator

@cgorman cgorman commented Jul 11, 2023

numpy.product was deprecated in favor of numpy.prod (see https://numpy.org/devdocs/release/1.25.0-notes.html)

@cgorman
Update deprecated numpy method calls
1162cbb 
`numpy.product` was deprecated in favor of `numpy.prod`.
@cgorman cgorman added the bug Something isn't working label Jul 11, 2023
@cgorman cgorman requested a review from hackermd July 11, 2023 22:15
@cgorman cgorman mentioned this pull request Sep 5, 2023
Merged
@cgorman cgorman requested a review from pieper September 5, 2023 19:17
pieper
pieper approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@pieper pieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems non-controversial. It wasn't clear to me how old of a numpy people would have to be using to be hurt by this but I suspect anyone doing dicomweb would be using a new enough version.

@pieper pieper merged commit 4063e75 into master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieper pieper pieper approved these changes

@hackermd hackermd Awaiting requested review from hackermd

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgorman @pieper