-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wpewebkit: Enable QtWPE build support for Qt6 for 2.46.0 #506
base: main
Are you sure you want to change the base?
Conversation
@pabelenda Please do a review! |
Hi @Qingwu-Li, thank you for the PR. We really appreciate all contributions to the project. I have a few comments regarding the pull request:
|
0d4f8a1
to
2aa0395
Compare
Hello @psaavedra , yes Qt6 WPE not supported in 2.44, |
We are going to release 2.46.0 soon. It would be great if you could update this PR with an update to that version when it's available in some weeks. |
This PR (#509) will move the WPE version to 2.46. I could be very happy to integrate your changes after this 509 is merged if you make the adaptations in this 506 PR. |
2aa0395
to
a1f2839
Compare
a1f2839
to
0dace1e
Compare
#509 is ready and landed. Let's trigger the Actions for this PR. |
|
||
CMAKE_QT_OECONF = "\ | ||
-DUSE_QT6=ON \ | ||
-DENABLE_WPE_PLATFORM=ON \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this really needed (cc: @aperezdc )?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the Qt6 integration uses WPEPlatform. In this case it's okay to rely on it even when its API is not yet considered stable becayse the Qt6 integration is also in the WebKit tree and the expectation is that we would keep it working alongside changes done to WPEPlatform.
Also, only the base ENABLE_WPE_PLATFORM=ON
is needed, the rest of the ENABLE_WPE_PLATFORM_{DRM,WAYLAND,..}
options can be OFF
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aperezdc if I set as
ENABLE_WPE_PLATFORM=ON
ENABLE_WPE_PLATFORM_DRM=OFF
ENABLE_WPE_PLATFORM_HEADLESS=OFF
ENABLE_WPE_PLATFORM_WAYLAND=OFF
I got folowing errors
Source/WebKit/WPEPlatform/wpe/WPEBufferSHM.cpp:29:10: fatal error: WPEEnumTypes.h: No such file or directory
| 29 | #include "WPEEnumTypes.h"
| | ^~~~~~~~~~~~~~~~
It seems need at lease set on of then to ON
Keep those on as default?
...-browser/wpewebkit/wpewebkit/0003-WPE-Platform-fix-wpe_toplevel_qtquick-has-not-been-d.patch
Outdated
Show resolved
Hide resolved
...-browser/wpewebkit/wpewebkit/0004-WPE-Platform-fix-wpe_view_resize-was-not-declared-is.patch
Outdated
Show resolved
Hide resolved
4b11537
to
8112414
Compare
@Qingwu-Li is this PR still a Draft? |
Refactor Qt configurations into separate files to accommodate Qt5 and Qt6 based on BBFILE_COLLECTIONS. Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
8112414
to
1d18a3e
Compare
modifed Upstream-Status to |
Tested with QT6 build
know issue:
gcc 11 may failed build neon.h failed for arm64, see Qingwu-Li/WebKit@176cb80