Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wpewebkit: Bump to version 2.44.4 #505

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

aperezdc
Copy link
Member

@aperezdc aperezdc commented Aug 27, 2024

Changes:

  • Add quirk to allow totale.rosettastone.com to load properly.
  • Decrease input notifications for gamepad inputs.
  • Disable the gst-libav AAC decoder.
  • Make gamepads visible on axis movements, and not only on button presses.
  • Make user scripts and style sheets visible in the Web Inspector.
  • Undeprecate console message API and make it available in 2022 API.
  • Use optimized assembler BoringSSL modules with USE_LIBWEBRTC enabled.
  • Use the geolocation portal where available, with the existing Geoclue as fallback if the portal is not usable.
  • Fix accelerated images dissapearing after scrolling.
  • Fix mouse location in WebDriver when output device scaling is in effect.
  • Fix not being able to jump-to-source in Web Inspector canvas traces.
  • Fix not being able to scroll list of WebGL shader programs in the Web Inspector.
  • Fix the build with GBM support when the WPEPlatform library is disabled.
  • Fix linker relocation errors on Debug/RelWithDebInfo builds.
  • Fix crashes when built with Clang with Link-Time Optimization (LTO).
  • Fix the build on 32-bit ARM with USE_LIBWEBRTC enabled.
  • Fix the build with ENABLE_WEBAUDIO disabled.
  • Fix touch input event propagation.
  • Fix video flickering with DMA-BUF sink.
  • Fix web process cache suspend/resume when sandbox is enabled.
  • Fix several crashes and rendering issues.

Release notes:

Copy link
Member

@psaavedra psaavedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is an issue with a patch

CmdError('quilt --quiltrc /home/bot/yocto-webkit-kirkstone/builds/raspberrypi3-mesa-wpe-2-44/tmp/work/cortexa7t2hf-neon-vfpv4-poky-linux-gnueabi/wpewebkit/2.44.3-r0/recipe-sysroot-native/etc/quiltrc push', 0, 'stdout: Applying patch 0004-Revert-Cherry-pick-272448.770-safari-7618-branch-6d3.patch
The next patch would delete the file JSTests/wasm/stress/many-calls-results-on-stack.js,
which does not exist! Applying it anyway.
patching file JSTests/wasm/stress/many-calls-results-on-stack.js
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- rejects in file JSTests/wasm/stress/many-calls-results-on-stack.js
patching file Source/JavaScriptCore/wasm/WasmBBQJIT.cpp
Patch 0004-Revert-Cherry-pick-272448.770-safari-7618-branch-6d3.patch can be reverse-applied

@aperezdc aperezdc force-pushed the aperezdc/wpewebkit-2.44.3 branch 2 times, most recently from c3f3e11 to 68a0054 Compare September 6, 2024 13:13
@aperezdc aperezdc changed the title wpewebkit: Bump to version 2.44.3 wpewebkit: Bump to version 2.44.4 Sep 6, 2024
@aperezdc
Copy link
Member Author

aperezdc commented Sep 6, 2024

Switched the update to 2.44.4 instead, which already includes the two patches I was trying to include along with .3

@aperezdc
Copy link
Member Author

aperezdc commented Sep 6, 2024

The failed CI jobs have the following error, which seems unrelated to the changes in this PR:

ERROR: Layer raspberrypi is not compatible with the core layer which only supports these series: scarthgap (layer is compatible with styhead)

@psaavedra
Copy link
Member

The failed CI jobs have the following error, which seems unrelated to the changes in this PR:

ERROR: Layer raspberrypi is not compatible with the core layer which only supports these series: scarthgap (layer is compatible with styhead)

This should fix the error: 4f2f85c

Changes:

* Add quirk to allow totale.rosettastone.com to load properly.
* Decrease input notifications for gamepad inputs.
* Disable the gst-libav AAC decoder.
* Make gamepads visible on axis movements, and not only on button
  presses.
* Make user scripts and style sheets visible in the Web Inspector.
* Undeprecate console message API and make it available in 2022 API.
* Use optimized assembler BoringSSL modules with USE_LIBWEBRTC enabled.
* Use the geolocation portal where available, with the existing Geoclue
  as fallback if the portal is not usable.
* Fix accelerated images dissapearing after scrolling.
* Fix mouse location in WebDriver when output device scaling is in
  effect.
* Fix not being able to jump-to-source in Web Inspector canvas traces.
* Fix not being able to scroll list of WebGL shader programs in the Web Inspector.
* Fix the build with GBM support when the WPEPlatform library is disabled.
* Fix linker relocation errors on Debug/RelWithDebInfo builds.
* Fix crashes when built with Clang with Link-Time Optimization (LTO).
* Fix the build on 32-bit ARM with USE_LIBWEBRTC enabled.
* Fix the build with ENABLE_WEBAUDIO disabled.
* Fix touch input event propagation.
* Fix video flickering with DMA-BUF sink.
* Fix web process cache suspend/resume when sandbox is enabled.
* Fix several crashes and rendering issues.

Release notes:

  https://wpewebkit.org/release/wpewebkit-2.44.4.html
  https://wpewebkit.org/release/wpewebkit-2.44.3.html
  https://wpewebkit.org/release/wpewebkit-2.44.2.html
@aperezdc
Copy link
Member Author

aperezdc commented Sep 9, 2024

The failed CI jobs have the following error, which seems unrelated to the changes in this PR:

ERROR: Layer raspberrypi is not compatible with the core layer which only supports these series: scarthgap (layer is compatible with styhead)

This should fix the error: 4f2f85c

Thanks! I have rebased the patch, so we should expect all the CI builds to pass now. I will prepare a separate PR updating WebKitGTK to 2.44.4, which was just released today.

@psaavedra
Copy link
Member

@aperezdc all tests passed now. Feel free to land the change.

Copy link
Member

@psaavedra psaavedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aperezdc aperezdc merged commit 5cbbc9e into main Sep 10, 2024
8 checks passed
@aperezdc aperezdc deleted the aperezdc/wpewebkit-2.44.3 branch September 10, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants