Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the rendering of service custom variable in Dependencies form #2298

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

raviks789
Copy link
Collaborator

Earlier the director did not support the rendering of service custom variables for Parent Service in Dependencies form. Here, this issue is fixed.

fixes #2289

@raviks789 raviks789 force-pushed the fix/render-service-custom-var branch 6 times, most recently from 30a04f8 to 804f2a7 Compare March 10, 2021 12:54
@lippserd lippserd removed their request for review February 21, 2022 11:07
@cla-bot cla-bot bot added the cla/signed label Sep 21, 2023
@raviks789 raviks789 force-pushed the fix/render-service-custom-var branch from 771d718 to 7b5d926 Compare February 1, 2024 10:38
@raviks789 raviks789 requested review from nilmerg and removed request for Thomas-Gelf February 1, 2024 11:51
application/forms/IcingaDependencyForm.php Outdated Show resolved Hide resolved
application/forms/IcingaDependencyForm.php Outdated Show resolved Hide resolved
application/forms/IcingaDependencyForm.php Outdated Show resolved Hide resolved
library/Director/Objects/IcingaDependency.php Outdated Show resolved Hide resolved
library/Director/Objects/IcingaDependency.php Outdated Show resolved Hide resolved
@nilmerg nilmerg added this to the v1.11.1 milestone Feb 2, 2024
@raviks789 raviks789 force-pushed the fix/render-service-custom-var branch 2 times, most recently from 2f95d64 to 347c38c Compare February 2, 2024 14:28
library/Director/Objects/IcingaDependency.php Outdated Show resolved Hide resolved
application/forms/IcingaDependencyForm.php Outdated Show resolved Hide resolved
@raviks789 raviks789 force-pushed the fix/render-service-custom-var branch 2 times, most recently from 1cb219d to e110a51 Compare February 5, 2024 11:30
application/forms/IcingaDependencyForm.php Outdated Show resolved Hide resolved
application/forms/IcingaDependencyForm.php Outdated Show resolved Hide resolved
application/forms/IcingaDependencyForm.php Outdated Show resolved Hide resolved
application/forms/IcingaDependencyForm.php Outdated Show resolved Hide resolved
@raviks789 raviks789 force-pushed the fix/render-service-custom-var branch 5 times, most recently from d417626 to 70e6e75 Compare February 6, 2024 16:55
@raviks789 raviks789 force-pushed the fix/render-service-custom-var branch from 70e6e75 to efe438c Compare February 7, 2024 09:01
@nilmerg nilmerg merged commit 6351df6 into master Feb 7, 2024
15 checks passed
@nilmerg nilmerg deleted the fix/render-service-custom-var branch February 7, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renders wrong config
3 participants