IcingaDependencyForm: Make parent host and parent service element val…

…ues removeable
Icinga · Feb 7, 2024 · efe438c · efe438c
1 parent 5f31180
commit efe438c
Showing 1 changed file with 14 additions and 10 deletions.
diff --git a/application/forms/IcingaDependencyForm.php b/application/forms/IcingaDependencyForm.php
@@ -344,18 +344,22 @@ public function createApplyRuleFor(IcingaDependency $dependency)
     protected function handleProperties(DbObject $object, &$values)
     {
         if ($this->hasBeenSent()) {
-            if (isset($values['parent_host'])
-                && $this->isCustomVar($values['parent_host'])
-            ) {
-                $values['parent_host_var'] = \trim($values['parent_host'], '$');
-                $values['parent_host'] = '';
+            if (isset($values['parent_host'])) {
+                if ($this->isCustomVar($values['parent_host'])) {
+                    $values['parent_host_var'] = \trim($values['parent_host'], '$');
+                    $values['parent_host'] = '';
+                } else {
+                    $values['parent_host_var'] = '';
+                }
             }
 
-            if (isset($values['parent_service'])
-                && $this->isCustomVar($values['parent_service'])
-            ) {
-                $values['parent_service_by_name'] = trim($values['parent_service'], '$');
-                $values['parent_service'] = '';
+            if (isset($values['parent_service'])) {
+                if ($this->isCustomVar($values['parent_service'])) {
+                    $values['parent_service_by_name'] = trim($values['parent_service'], '$');
+                    $values['parent_service'] = '';
+                } else {
+                    $values['parent_service_by_name'] = '';
+                }
             }
         }