Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3657 4393 modular explore plus guestbook #4413

Closed
wants to merge 24 commits into from
Closed

3657 4393 modular explore plus guestbook #4413

wants to merge 24 commits into from

Commits on Jan 3, 2018

  1. stub out modular explore #3657 #4249

    @pdurbin
    pdurbin committed Jan 3, 2018
    Configuration menu
    Copy the full SHA
    5ae8418 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2018

  1. Update the description for the Data Explorer

    kevinworthington authored Jan 4, 2018
    Configuration menu
    Copy the full SHA
    488b604 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #4397 from kevinworthington/patch-2 

    Update the description for the Data Explorer
    @pdurbin
    pdurbin authored Jan 4, 2018
    Configuration menu
    Copy the full SHA
    bd17812 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2018

  1. get test passing, {siteUrl} is now a valid reserved word #3657

    @pdurbin
    pdurbin committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    61c4936 View commit details
    Browse the repository at this point in the history

  2. differentiate external tools under own dropdown for now #3657

    @pdurbin
    pdurbin committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    6538b93 View commit details
    Browse the repository at this point in the history

  3. make external explore tools available on dataset page too #3657

    @pdurbin
    pdurbin committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    b3be37e View commit details
    Browse the repository at this point in the history

  4. Data Explorer expects fileId not fileid #4249 #3657

    @pdurbin
    pdurbin committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    e873c6e View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2018

  1. add type to externaltool table for "explore" vs "configure" #3657

    @pdurbin
    pdurbin committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    233cdc1 View commit details
    Browse the repository at this point in the history

  2. externaltool type enum is stored in ALL CAPS #3657

    @pdurbin
    pdurbin committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    bcca40b View commit details
    Browse the repository at this point in the history

  3. put external tools under Explore button dropdown #3657

    @pdurbin
    pdurbin committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    5d18067 View commit details
    Browse the repository at this point in the history

  4. have external tools respect downloadPopupRequired #3657 

    Note the FIXME that this is working from the file page but not the
dataset page.
    @pdurbin
    pdurbin committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    0e1c1e9 View commit details
    Browse the repository at this point in the history

  5. mention external tools in Data Exploration Guide #3657

    @pdurbin
    pdurbin committed Jan 8, 2018
    Configuration menu
    Copy the full SHA
    79161d0 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2018

  1. #4393 fix gb record update and validators

    @sekmiller
    sekmiller committed Jan 9, 2018
    Configuration menu
    Copy the full SHA
    44fff97 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2018

  1. #4393 add validation messages directly to required custom questions

    @sekmiller
    sekmiller committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    db4b868 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into 4393-guestbook-not-enforcing-reqd-fields

    @sekmiller
    sekmiller committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    e916af0 View commit details
    Browse the repository at this point in the history

  3. get TwoRavens working again (FIXME for external tools) #3657 

    Here we are differentiating between popups for TwoRavens ("explore") and
popups for external tools ("externalTool").
    @pdurbin
    pdurbin committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    f460d5b View commit details
    Browse the repository at this point in the history

  4. get external tool popup working on dataset page #3657

    @pdurbin
    pdurbin committed Jan 10, 2018
    Configuration menu
    Copy the full SHA
    ef87fde View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2018

  1. only show explore tools for tabular data #3657 

    We don't want to show explore tools for images and such until there is a
use case, at which time we can add a column to the externaltool table.
    @pdurbin
    pdurbin committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    4204279 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into 3657-modular-explore #3657

    @pdurbin
    pdurbin committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    0f55916 View commit details
    Browse the repository at this point in the history

  3. #4393 fixes from code review

    @sekmiller
    sekmiller committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    5c5b19b View commit details
    Browse the repository at this point in the history

  4. Merge branch #3657 '4393-guestbook-not-enforcing-reqd-fields' into 36… 

    …57-4393-modular-expore-plus-guestbook

Conflicts (just imports):
src/main/java/edu/harvard/iq/dataverse/GuestbookResponseServiceBean.java
    @pdurbin
    pdurbin committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    a72941b View commit details
    Browse the repository at this point in the history

  5. get validation working on external tools #3657

    @pdurbin
    pdurbin committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    cfbae2e View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into 4393-guestbook-not-enforcing-reqd-fields

    @sekmiller
    sekmiller committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    bb51bd2 View commit details
    Browse the repository at this point in the history

  7. Merge branch #3657 '4393-guestbook-not-enforcing-reqd-fields' into 36… 

    …57-4393-modular-explore-plus-guestbook
    @pdurbin
    pdurbin committed Jan 11, 2018
    Configuration menu
    Copy the full SHA
    3519747 View commit details
    Browse the repository at this point in the history